From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D8E34428DA;
	Thu,  6 Apr 2023 17:45:23 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id ABEB642D0E;
	Thu,  6 Apr 2023 17:45:23 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id CE00441153
 for <dev@dpdk.org>; Thu,  6 Apr 2023 17:45:21 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id EF7DC210DF10; Thu,  6 Apr 2023 08:45:20 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EF7DC210DF10
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1680795920;
 bh=yWrQWeS4zB2oW/fYloHX+zKEDydzATTlaKPf+KACAEE=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=sZ9G77BnB3/Sg5ts7BiRekEEE5BErUuMouov/xlGFI3RpE3690LaJo4rFveAQeCsU
 XlP/SafYaZmDjZaKisF0n1sNFWYL27CaCMv0HgJf12SczN2sH0MCIraa0kqQ9JSfh2
 M6OcGgXV9jGsfdNYnB0up1BE+PIYUA270DqweKMo=
Date: Thu, 6 Apr 2023 08:45:20 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, thomas@monjalon.net,
 mb@smartsharesystems.com, konstantin.ananyev@huawei.com
Subject: Re: [PATCH v3 10/11] telemetry: disable json print formatting with
 msvc
Message-ID: <20230406154520.GA20573@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com>
 <1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com>
 <1680741919-22102-11-git-send-email-roretzla@linux.microsoft.com>
 <ZC6P8y9QP0wG32zr@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZC6P8y9QP0wG32zr@bricha3-MOBL.ger.corp.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Apr 06, 2023 at 10:25:07AM +0100, Bruce Richardson wrote:
> On Wed, Apr 05, 2023 at 05:45:18PM -0700, Tyler Retzlaff wrote:
> > VLAs are unsafe and will never be implemented in MSVC. When compiling
> > with MSVC just return immediately indicating 0 output characters
> > formatted.
> > 
> > For now telemetry doesn't work on Windows, we will revisit support for
> > the telemetry library sometime after we establish the DPDK unit tests.
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> >  lib/telemetry/telemetry_json.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> I'm guessing this patch can be dropped if patchset [1] is merged, right?

Absolutely. I'll take a look at the referenced series soon.

> 
> /Bruce
> 
> [1] http://patches.dpdk.org/project/dpdk/list/?series=27629