* Dpaa2 driver using system("echo...")
@ 2023-04-10 16:21 Stephen Hemminger
2023-04-28 10:12 ` Sachin Saxena (OSS)
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2023-04-10 16:21 UTC (permalink / raw)
To: Hemant Agrawal, Sachin Saxena; +Cc: dev
When the CodeQl (https://codeql.github.com/) is run against DPDK,
one of the issues it reports is the unsafe usage of system() in code.
I reported and fixed one of these issues in the dpaa2 driver
https://patchwork.dpdk.org/project/dpdk/patch/20220602214957.150071-1-stephen@networkplumber.org/
but it seems to have been ignored.
Could one of the maintainers of that driver review it?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Dpaa2 driver using system("echo...")
2023-04-10 16:21 Dpaa2 driver using system("echo...") Stephen Hemminger
@ 2023-04-28 10:12 ` Sachin Saxena (OSS)
0 siblings, 0 replies; 2+ messages in thread
From: Sachin Saxena (OSS) @ 2023-04-28 10:12 UTC (permalink / raw)
To: Stephen Hemminger, Hemant Agrawal, Sachin Saxena; +Cc: dev
On 4/10/2023 9:51 PM, Stephen Hemminger wrote:
> When the CodeQl (https://codeql.github.com/) is run against DPDK,
> one of the issues it reports is the unsafe usage of system() in code.
>
> I reported and fixed one of these issues in the dpaa2 driver
> https://patchwork.dpdk.org/project/dpdk/patch/20220602214957.150071-1-stephen@networkplumber.org/
> but it seems to have been ignored.
>
> Could one of the maintainers of that driver review it?
>
Hello Stephen,
Apology for the delay and thanks for the changes suggested for dpaa2
driver improvement.
I have reviewed your changes and logically they look fine. When testing,
found issue of memory corruption that I have fixed over your changes. I
will send a 'v2' patch in context of your previous patch including this
fix for dpaa2 platform.
--
Thanks,
Sachin Saxena
(NXP)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-28 10:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-10 16:21 Dpaa2 driver using system("echo...") Stephen Hemminger
2023-04-28 10:12 ` Sachin Saxena (OSS)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).