From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18E9242911; Mon, 10 Apr 2023 18:22:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9441B40DDC; Mon, 10 Apr 2023 18:22:00 +0200 (CEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id E77D240A81 for ; Mon, 10 Apr 2023 18:21:58 +0200 (CEST) Received: by mail-pj1-f42.google.com with SMTP id d22-20020a17090a111600b0023d1b009f52so7827408pja.2 for ; Mon, 10 Apr 2023 09:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; t=1681143718; x=1683735718; h=content-transfer-encoding:mime-version:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=K5gg1m3Yw4ggW0YSWItgsbsS4OmcSCBf4Dw9awQ1BoQ=; b=HAdaLSxBynRtS9D+hjwGwWdX/jz7boXbaJ0l8O8y3iZhJTdDC6L4Lru97OcIaJTFXy fE7BjGykcMlndu3yx7gi5FY0Q5ErjV/gDJwU1JyPEqsJ3f/dJSMwR0Is3loGLXM7KZ+d yRPjprUNwaw7Gu6GdMkzrGJZpgrRQNp3aZOKLExl4y/H4sokJHiYKX3h1sHa8vZL5UfM EI6Q7BH9H73wwuMg/M8rcBBLwT/kCaBuPUwwAKbIahPoq0JXhoPXRiOWVQocjf94MuEu yGYqCAV5P3SNwE/pxgzSurcT5SkA2LonmEFKxSX1j9cuwgZtDSqfkpa4Zp9Fc2BEpOfW xgGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681143718; x=1683735718; h=content-transfer-encoding:mime-version:message-id:subject:cc:to :from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K5gg1m3Yw4ggW0YSWItgsbsS4OmcSCBf4Dw9awQ1BoQ=; b=tBMf3IPZDvN0nmfn0SoW4ArCZFbgvpa3ZzIxImqNNVUWFNt3imBmT+MZ2VvP755iKk f/T5eGtC6YwTvJhdkSNg3UMI6N7H0EtDKpYyeo+43cQHIiduTGqWQbmijVKEbzeQuI7H 1pPlYhSC6+jsUbzsBAL7lElrN2gPvx3ewjRg/QflTV/J6JIJ5Q8XkFyN7ylNOwEpNg+L LKc+vz268kZavhXvTWMdFn9IKqKszWuwMW+0ud3ZmDZt9WMe8dXOOUZRZ5lYVpFfhzFG 1asLAbwyjr5zyf43c6cOKl0zx2M2MK9BCQW7uQpnMuj8M3KCKTTaeSEusrAVrtpFto/K hl5Q== X-Gm-Message-State: AAQBX9f05t6GC+4lo3Wgo+9S8kT3SDg0Rvv2z393hhUEnfk9CvoOS4fF 2QAcim9/41xGBtvwwPzRGNmruQ== X-Google-Smtp-Source: AKy350YXaX7dv39e0QoMoTn4nlA7Fx/3x65j72mEY8JPl2NBmZrDQ0tS3kOmxiqs+v9zGzK3f+E4NA== X-Received: by 2002:a17:90b:2247:b0:244:ae65:8a8d with SMTP id hk7-20020a17090b224700b00244ae658a8dmr14963365pjb.31.1681143718062; Mon, 10 Apr 2023 09:21:58 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id s1-20020a17090ae68100b00234115a2221sm6893111pjy.39.2023.04.10.09.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 09:21:57 -0700 (PDT) Date: Mon, 10 Apr 2023 09:21:56 -0700 From: Stephen Hemminger To: Hemant Agrawal , Sachin Saxena Cc: dev@dpdk.org Subject: Dpaa2 driver using system("echo...") Message-ID: <20230410092156.546ffaef@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When the CodeQl (https://codeql.github.com/) is run against DPDK, one of the issues it reports is the unsafe usage of system() in code. I reported and fixed one of these issues in the dpaa2 driver https://patchwork.dpdk.org/project/dpdk/patch/20220602214957.150071-1-stephen@networkplumber.org/ but it seems to have been ignored. Could one of the maintainers of that driver review it?