From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55E3442942; Fri, 14 Apr 2023 16:52:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 274AF40144; Fri, 14 Apr 2023 16:52:35 +0200 (CEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 3CD7A400D5 for ; Fri, 14 Apr 2023 16:52:34 +0200 (CEST) Received: by mail-pj1-f43.google.com with SMTP id b2-20020a17090a6e0200b002470b249e59so7835948pjk.4 for ; Fri, 14 Apr 2023 07:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1681483953; x=1684075953; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Qr88A9FZvRD22zWHQbnTeMEknPkN7l+ynb/WYtfoCbw=; b=ULgXP7mvtJe98JP612mzhs0cYzoBJhfdhP2Rq+GfuFZ0axebaowusggSeG/yfd862/ sP2esEXXbOlvUsK+iSqfiNSedbLC3EIirIJ/7PICI4nKf16kgZP0jEN5rkqpRKYwYqs4 a717u1h7f7vZK23KZIXvLkA4IAyW599hXojNlzFgHEhQIBzU5+b7tsWfaB+TyoQuus0M 2dKc/QKpOA5v7K2NXg2pdUSOarSiGaINpSttABypASMw56kqKLz4R2PaKmOJA5iq7vwz Hmrun3UxTAKYkEqVh8r7fTgl744W+Rh1UQ1w08HRdu9bz0LVyYE1JBAe8u4zjcKwkna0 U/uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681483953; x=1684075953; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qr88A9FZvRD22zWHQbnTeMEknPkN7l+ynb/WYtfoCbw=; b=D0vk5x3hl0gnVnJoFVJCX9SQb4IaGnY0davHZ3xMTDbsx7E8rtveRRhJSBxzC8ysLg UXULUmudsgdWcJIRyIcX4T4zPqBaPXkrUV1zHLpjhs1opP5gtO1VPWxOUeqGSV7OXfnN Ng1QCCORv24gn15hk4ciagQcK1PQ8yrpocmbfJC7CNcR88NUzCJIWdiNdyiYMKxR9H6z LGLv09zbAyhhiFmflnp7mrROG03houXjD2PcnG1dwVPeowmiRAlrxaDF1WlL8VG9MVRW R10RgyIUHdaM57AUANagJoCX/728XEiR5LCl5rO5SW44gyZ6sx13HwNKi01F2spC4jb2 kwLA== X-Gm-Message-State: AAQBX9dxF4MlsNgDskUz8HZ5mhtX5r1Y32dor0C4TpCeAdIMoJSbcEQh R5gdwmZxn3e6DdDhxfq6XgdsaA== X-Google-Smtp-Source: AKy350Yh+ceedWTSNiwFCT+Dw+hrDdte9jUoz0biKlnGiumW0oBD+/UmxNafMP+4oaHnt1Mdz39TcQ== X-Received: by 2002:a17:90a:4a17:b0:247:2d48:76f7 with SMTP id e23-20020a17090a4a1700b002472d4876f7mr4097212pjh.44.1681483953250; Fri, 14 Apr 2023 07:52:33 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x8-20020a17090a1f8800b0023fbb21214bsm4755496pja.17.2023.04.14.07.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 07:52:33 -0700 (PDT) Date: Fri, 14 Apr 2023 07:52:30 -0700 From: Stephen Hemminger To: Volodymyr Fialko Cc: , Reshma Pattan , , Subject: Re: [PATCH] reorder: improve buffer structure layout Message-ID: <20230414075230.1a9279be@hermes.local> In-Reply-To: <20230414084344.271602-1-vfialko@marvell.com> References: <20230414084344.271602-1-vfialko@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 14 Apr 2023 10:43:43 +0200 Volodymyr Fialko wrote: > diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c > index f55f383700..7418202b04 100644 > --- a/lib/reorder/rte_reorder.c > +++ b/lib/reorder/rte_reorder.c > @@ -46,9 +46,10 @@ struct rte_reorder_buffer { > char name[RTE_REORDER_NAMESIZE]; > uint32_t min_seqn; /**< Lowest seq. number that can be in the buffer */ > unsigned int memsize; /**< memory area size of reorder buffer */ > + int is_initialized; /**< flag indicates that buffer was initialized */ > + > struct cir_buffer ready_buf; /**< temp buffer for dequeued entries */ > struct cir_buffer order_buf; /**< buffer used to reorder entries */ > - int is_initialized; > } __rte_cache_aligned; > > static void Since this is ABI change it will have to wait for 23.11 release