From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 032CE42942; Fri, 14 Apr 2023 17:30:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E775340144; Fri, 14 Apr 2023 17:30:38 +0200 (CEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id BAF1C400D5 for ; Fri, 14 Apr 2023 17:30:37 +0200 (CEST) Received: by mail-pj1-f42.google.com with SMTP id w11so19157158pjh.5 for ; Fri, 14 Apr 2023 08:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1681486237; x=1684078237; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=aj1Z0h3T6E5vfbo1l8oVWQkK9H27ah3C1jNux0gZcMU=; b=waXtR3TDyDaSIj1a+uyJ3Nq7IW016LU3kTnuBdN8Z3/dZLeaaKCuhgy3RmbeH5ikuO Wr0QMxstxHu8B6/k6IJSZz7UKq4ga6hZyABoYXHHbZ3CxyOLxWEdQznQhhDQExEyh3Lb HSE3T7PLALTHdPLmn1hsqoFIOb38vN7TvOMFHzpRHm68qvkJOronOLc9gE0uPxVArs5W o80t83kW2Hte3WGc13g2b0voaAtk5W49xBun+uoO5x3TisRlIPglwBjcpK8rF908rYFy VlPFrd91WXlBX+8UcY2vDaoW3Qlx9SQ0PkOOn5UXK1RZFvkvhXnjpaiehONiJxTweLM+ EpnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681486237; x=1684078237; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aj1Z0h3T6E5vfbo1l8oVWQkK9H27ah3C1jNux0gZcMU=; b=Q/ZKF/f02OgZ5avera2zy/nVEEMhDZ1YDRIK/7xH092vhPdecYvMCxLoux73kjnqbm UhdEFsTxuCFZwsusQwdWV5jr6rId5N1huLBYSzNy+/Q+pSVev5viHzlqInYNNQf+Nc5i zS6yHDXTk84XdubLBfAcOVLparRYM8o97x+5Qazmu81l7Px1R4hxP98elYBLzGxlis5U IdA6hBM+UTkAJvtNtLToEDWswyqYSlaxRqwbr5gzp1XZ0XoI3VRIZb4PkxoGbfdHK7Wr 1soIvmczJoselE/X7KVMMESKQYKIg7YkW8ggRs7rTWZpRX80nzemn1awcgflKYquJlf6 0kkQ== X-Gm-Message-State: AAQBX9epHYi5D2P2eN8GuGBJwt67AEriW/Gt03VWCED51Z7Dyzg1Dks+ 3WjtoeLy1DP19CWzDLUZxGKtbg== X-Google-Smtp-Source: AKy350ZVNmfMzwQaNTtv3wx0fp7c4Kqjg89l2sZkwWouKFUlCL6L6Qn1nBu04Qi794GyVopnyT7X5g== X-Received: by 2002:a17:90b:3a8a:b0:237:b5d4:c0cc with SMTP id om10-20020a17090b3a8a00b00237b5d4c0ccmr5917103pjb.39.1681486236846; Fri, 14 Apr 2023 08:30:36 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id g69-20020a636b48000000b005133f658f1asm2891033pgc.94.2023.04.14.08.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 08:30:36 -0700 (PDT) Date: Fri, 14 Apr 2023 08:30:34 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: Volodymyr Fialko , , Reshma Pattan , , Subject: Re: [PATCH] reorder: improve buffer structure layout Message-ID: <20230414083034.2f82174c@hermes.local> In-Reply-To: References: <20230414084344.271602-1-vfialko@marvell.com> <20230414075230.1a9279be@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 14 Apr 2023 15:54:13 +0100 Bruce Richardson wrote: > On Fri, Apr 14, 2023 at 07:52:30AM -0700, Stephen Hemminger wrote: > > On Fri, 14 Apr 2023 10:43:43 +0200 > > Volodymyr Fialko wrote: > > > > > diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c > > > index f55f383700..7418202b04 100644 > > > --- a/lib/reorder/rte_reorder.c > > > +++ b/lib/reorder/rte_reorder.c > > > @@ -46,9 +46,10 @@ struct rte_reorder_buffer { > > > char name[RTE_REORDER_NAMESIZE]; > > > uint32_t min_seqn; /**< Lowest seq. number that can be in the buffer */ > > > unsigned int memsize; /**< memory area size of reorder buffer */ > > > + int is_initialized; /**< flag indicates that buffer was initialized */ > > > + > > > struct cir_buffer ready_buf; /**< temp buffer for dequeued entries */ > > > struct cir_buffer order_buf; /**< buffer used to reorder entries */ > > > - int is_initialized; > > > } __rte_cache_aligned; > > > > > > static void > > > > Since this is ABI change it will have to wait for 23.11 release > > It shouldn't be an ABI change. This struct is defined in a C file, rather > than a header, so is not exposed to end applications. > > /Bruce Sorry, Bruce is right. You might want to use uint8_t or bool for a simple flag.