From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DB2B42450; Sun, 16 Apr 2023 00:52:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96E2640EDE; Sun, 16 Apr 2023 00:52:32 +0200 (CEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 0BB30406B3 for ; Sun, 16 Apr 2023 00:52:30 +0200 (CEST) Received: by mail-pj1-f43.google.com with SMTP id cm18-20020a17090afa1200b0024713adf69dso9912413pjb.3 for ; Sat, 15 Apr 2023 15:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1681599150; x=1684191150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=rsZXk1O0RKqEtWWXkPm5pMay2UY8r1ED1QxiysQMfAQ=; b=xwsieYfVN9qfHXQBhRKImq1ed+6FF79bqxExmq7/Gr5Fa4Yv4sesG+JYJN/MZmvAUE FfpAC7xIEFEW9G/tkUsUJKHykNXCQx1Y8WIfLwo6baK4Cj24eHSQFwWLyKaUXQDNY2ZM VAgWaLUG33g1dAkZnCbrAsfMTfKR47fN+uGoP9AoP/ozIsYBffXrEMl0kNfwsI7U8cuu dbY+e119kDwJ0/lmuMQQ/MkJhIRQHJ9gPB8X/Y1O/eMaQ5EAF1qVlkoUrJn7Osm8lfFx FQASqjoT/aIXdE+t9mJSbzp3iA3+1n9OA4EG64Oduby6OS+uAYoDYKmBVIh/KFj+Hdfm v5KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681599150; x=1684191150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rsZXk1O0RKqEtWWXkPm5pMay2UY8r1ED1QxiysQMfAQ=; b=ced5zOkMuxnB6xKTDwRL3Rfi49AJjhbzAsW/z54OGxmWG30+HMgi73gWbReBbkOrHh 1/z1BFPU284FzF62TxtsEig1k+ytoXrbdy/MdKRaecdMvM1z1n4Su2bG/JSZZC5c8UZp VTmtNHW/IVYMvXw+n8lYnTTjVStv+rjjanhpV8UkupEC1SH5Y8zj7+5mdzL5TNPZg2qE IFo2KVreqryk4EcZo6MFwah7M22ZYBO2qZaRC/DXNI+kppVHIWVfK0Q3uo6iDhSwG2uR fkpIcW7nejIwRAr0tzqovwus+Gh6DhUOCXx/YU16Y60DWktKjZiEbjrKLBk3/CUjWuun R1pw== X-Gm-Message-State: AAQBX9cFqbKSNlQWMZxwxH98npot/rg6WiMGdwKFPVsRby7Kcqt/EwnR dgjQQPLnXpQexA0MkzR92MRKwg== X-Google-Smtp-Source: AKy350YG5Py8QVpFOMiQJ5PoulBlDxmHC4toH4ccbyn/8Xq1LZbCQY94MXohQGQVIJRoUT3jMOSG7w== X-Received: by 2002:a05:6a20:6a0d:b0:ec:628d:582 with SMTP id p13-20020a056a206a0d00b000ec628d0582mr13256682pzk.21.1681599150051; Sat, 15 Apr 2023 15:52:30 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id j10-20020a63ec0a000000b004fab4455748sm4731529pgh.75.2023.04.15.15.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 15:52:29 -0700 (PDT) Date: Sat, 15 Apr 2023 15:52:27 -0700 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: "Tyler Retzlaff" , , , , , Subject: Re: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC Message-ID: <20230415155227.28e647a2@hermes.local> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87880@smartserver.smartshare.dk> References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com> <1681421163-18578-1-git-send-email-roretzla@linux.microsoft.com> <1681421163-18578-12-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35D87878@smartserver.smartshare.dk> <20230414170226.GA10264@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <98CBD80474FA8B44BF855DF32C47DC35D8787D@smartserver.smartshare.dk> <20230415205226.GA9699@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <98CBD80474FA8B44BF855DF32C47DC35D87880@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 16 Apr 2023 00:41:54 +0200 Morten Br=C3=B8rup wrote: > > > > > > /** > > > > > > * Force a structure to be packed > > > > > > */ > > > > > > +#ifndef RTE_TOOLCHAIN_MSVC > > > > > > #define __rte_packed __attribute__((__packed__)) > > > > > > +#else > > > > > > +#define __rte_packed > > > > > > +#endif =20 Could there be cases this gets used for protocol headers or interacting with HW memory map, And if not packed then the code will not function correctly?