Re: [PATCH] usertools: enhance CPU layout

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri, 21 Apr 2023 10:28:31 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> lstopo existed already when introducing this python script.
> See its home page: https://www.open-mpi.org/projects/hwloc/
> 
> We talked about dropping the DPDK script in the past:
> http://inbox.dpdk.org/dev/20151127161008.GA27472@bricha3-MOBL3/
> 
> I recommend using "lstopo-no-graphics --merge"
> 
> > > Not sure how much farther DPDK should go in this area?
> > > Really should be a distro tool.  
> > 
> > Many thanks for your review and comments.
> > Have to say I'm a green hand in this field. Just imitate the existing code to write mine. So, still trying to understand and handle the comments :)

My refinements were more to reduce the amount of repeated code. The overall idea of reporting
more is a good one.

> > 
> > Better to understand more about our opinion of this script before send a v2 patch.
> > I've used 'lstopo'. It's a great tool.
> > To my opinion, considering there're Linux tools to show all kinds of information, the reason that DPDK has its own tool is to summarize and emphasize the information that is important to DPDK. Here it's that some cores are more powerful than others. When the users use a testpmd-like APP, they can choose the appropriate cores after DPDK reminds them about the difference between cores.
> > Add Thomas for more suggestions. Thanks.  
> 
> Adding Brice, hwloc maintainer.
> 
> I think it would be better to contribute to the hwloc project.
> If we need a different set of info, we can probably tune it with options.

The script had a purpose which was back when DPDK was first started.
But as systems get more complex, it becomes something that has to deal with lots
of corner cases; and if some other tool can it then that is better.