From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDF21429AE; Fri, 21 Apr 2023 17:15:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 666F44113C; Fri, 21 Apr 2023 17:15:46 +0200 (CEST) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id A8673410FB for ; Fri, 21 Apr 2023 17:15:44 +0200 (CEST) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-63b4960b015so1956996b3a.3 for ; Fri, 21 Apr 2023 08:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1682090144; x=1684682144; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=vbV7fG0NZYVkxvc8+0cBlB+JajrONCXrgX/MhSYXYoA=; b=eMnBGnv0Watxw8DlWNP2pjzeA6erMB0nUSqL+BoJTaFd/ub9eZITCofujVVf6Cms6o MzKzvOsInZlttQEQoVtSudgY5xcltUAOHe/cdA+wyGRbZx8Z7Q50T0JwYgoaKvLitE1K 3ClO+Z6oNpT5UzndvrcwkQ7tTt6z/Ce4fLF5x/PtzVO4+bMMtxtvDMJ3YHpWbBh0UOg2 pCx+r6bHctzX/VujYU0ag+mWKkmEAvY5rK61NpftCUTv908W1TWK72fTNb4B7wkeZvvj +E1U+2loRjc+Ry3kLDzTEfJM/5FbeavVkeZkpB1YiuE/V8q2PtmMy8X2QhK9FrxgWb9S apbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682090144; x=1684682144; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vbV7fG0NZYVkxvc8+0cBlB+JajrONCXrgX/MhSYXYoA=; b=CZRmm/GzU9Xe0EtEVoXhJ5hvmViqAv52s/q7zlJwanneve2lmpwUwVAL2vm6ZVW4CR UJPClJdQpoVc+0ikwMbp5wZMTFXyFSzT+g2XqL0niZ7AVzOuZ6XY1Yau0p03hFgL8r4j C+SeXziJRCxm+8Wo8P8Tc+/seZnYZMjjbbgEe8IRz54h39z8sna0rQuAwfbHhFEBPc43 9EUlpNyYGnbmljLsgTvaUfJbe9iZjB8V1W5fYne8PNlpCs+zqftAHqgxSsvTofSTHK1B WKuMv3egGK1sjJsiTLSd8oK8pR5jT6vJawyBQOQrOAYHK2VT3ap5Q53dP7KlSdpzqd97 r4vw== X-Gm-Message-State: AAQBX9duBEJy59pEI3PrD1YTDTlTergHWwkaNgCexD9tfL2nn8FWDhN/ Q1CPoN4ZFbo3PgKQWfilT5N++Q== X-Google-Smtp-Source: AKy350ZqTYoaxr8TfrCYFH7saHINomMW+2WyMppwzE8R5LltSSIVHKwey1wM03ykrcFd1XTSfVpq5w== X-Received: by 2002:a05:6a00:2d90:b0:63b:89ba:fca1 with SMTP id fb16-20020a056a002d9000b0063b89bafca1mr7422237pfb.10.1682090143719; Fri, 21 Apr 2023 08:15:43 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id bl11-20020a056a00280b00b0062dbafced27sm3142311pfb.27.2023.04.21.08.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 08:15:31 -0700 (PDT) Date: Fri, 21 Apr 2023 08:15:15 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: "Lu, Wenzhuo" , "dev@dpdk.org" , Brice Goglin , david.marchand@redhat.com Subject: Re: [PATCH] usertools: enhance CPU layout Message-ID: <20230421081515.3eca928d@hermes.local> In-Reply-To: <1980504.PIDvDuAF1L@thomas> References: <1681795541-68384-1-git-send-email-wenzhuo.lu@intel.com> <20230418094646.799b2fc3@hermes.local> <1980504.PIDvDuAF1L@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 21 Apr 2023 10:28:31 +0200 Thomas Monjalon wrote: > lstopo existed already when introducing this python script. > See its home page: https://www.open-mpi.org/projects/hwloc/ > > We talked about dropping the DPDK script in the past: > http://inbox.dpdk.org/dev/20151127161008.GA27472@bricha3-MOBL3/ > > I recommend using "lstopo-no-graphics --merge" > > > > Not sure how much farther DPDK should go in this area? > > > Really should be a distro tool. > > > > Many thanks for your review and comments. > > Have to say I'm a green hand in this field. Just imitate the existing code to write mine. So, still trying to understand and handle the comments :) My refinements were more to reduce the amount of repeated code. The overall idea of reporting more is a good one. > > > > Better to understand more about our opinion of this script before send a v2 patch. > > I've used 'lstopo'. It's a great tool. > > To my opinion, considering there're Linux tools to show all kinds of information, the reason that DPDK has its own tool is to summarize and emphasize the information that is important to DPDK. Here it's that some cores are more powerful than others. When the users use a testpmd-like APP, they can choose the appropriate cores after DPDK reminds them about the difference between cores. > > Add Thomas for more suggestions. Thanks. > > Adding Brice, hwloc maintainer. > > I think it would be better to contribute to the hwloc project. > If we need a different set of info, we can probably tune it with options. The script had a purpose which was back when DPDK was first started. But as systems get more complex, it becomes something that has to deal with lots of corner cases; and if some other tool can it then that is better.