From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2D5A429AF; Sat, 22 Apr 2023 01:20:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C662840EF1; Sat, 22 Apr 2023 01:20:52 +0200 (CEST) Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by mails.dpdk.org (Postfix) with ESMTP id F157940ED5 for ; Sat, 22 Apr 2023 01:20:50 +0200 (CEST) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-5560116959fso14994337b3.1 for ; Fri, 21 Apr 2023 16:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682119250; x=1684711250; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=muUp4a14ALUk+ECzH8TTwjOWiRQEK0mt2I09uCY09IM=; b=3A1AMWJv5+y1/SsfD0SHCn9V1Hd0Or3X+zp/U5ahPIlKy1CDd8TDuEGQKKTwDAAY3U PSGxxx6/B5qXKqkrKFDA9eyXB/6DNocAD3e23KGCNs/0eR0E/fX2eArI4vdHm7g5SVzF eFdG2MizvKbpq1W4ZEYC/LGLdvD1iqO21bJP5cTsDllGiq4vYQNqtNR4dnnFv50ArZey Mg+3RO+aQKXh9IjHjqGv6wcWupzJVYcQcff+ckIFwwyYCvitUKj5JHRswoVATRFwULJi Whfpcr9Q7QaJg28V48zGbPgkcDmss1GbIHd1Z2EjuiLRPifRAZmpbDSR+7SsTgMxObb1 GaCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682119250; x=1684711250; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=muUp4a14ALUk+ECzH8TTwjOWiRQEK0mt2I09uCY09IM=; b=HgtZFA1naBhgGcjVGqRLM07swEx+2zSuq2RG4e26Ygchvf1JcensNScDG+rFNx33Os Hi9I17aZRy2js6zkEHLp6wfaT/uwi13VT6OoLoGii+2bifTrCyIoB53zvB5wgX2aj8Fn bcoFwVWtIBwiqn8VBrtWSxfFoShM+qG3B9oV94s/v1s1drcBSX6qR9U3bWLYiPiPGsvb L/Cw6qpTW9ftYQnIvz6ZdvU6Nieysj6jIj0s9FIipzYkvceI+9CE2bZZkSmMZmUynCrZ sefbJeHGdohf+fFy9ZGXDuKwnNIABvHjShI/lNrPjrcbGhIVZMReqhpJQQ52w19ax6y8 J6qA== X-Gm-Message-State: AAQBX9fBcDe7GiZzUV/NlTkKpm6VTVvmYOc1kJW0dcVChLO0QArKr/3g gZbJg1oVhl89CFrrv8itRdqg0EH2xPymkg== X-Google-Smtp-Source: AKy350ZeWuTZwB9k/zBG2PKSXdzg5b12SIXGseIbrCklJAbnRPygR62sv2DIf5eWwrhqpI+t/owDJqUuEi6NBA== X-Received: from joshwash.sea.corp.google.com ([2620:15c:100:202:9893:df46:ecb4:256b]) (user=joshwash job=sendgmr) by 2002:a81:ad4e:0:b0:54f:646d:19c8 with SMTP id l14-20020a81ad4e000000b0054f646d19c8mr2191105ywk.3.1682119250338; Fri, 21 Apr 2023 16:20:50 -0700 (PDT) Date: Fri, 21 Apr 2023 16:20:22 -0700 In-Reply-To: <20230412181619.496342-1-joshwash@google.com> Mime-Version: 1.0 References: <20230412181619.496342-1-joshwash@google.com> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog Message-ID: <20230421232022.342081-1-joshwash@google.com> Subject: [PATCH v5] app/testpmd: txonly multiflow port change support From: Joshua Washington To: Aman Singh , Yuying Zhang Cc: dev@dpdk.org, Joshua Washington , Rushil Gupta Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Google cloud routes traffic using IP addresses without the support of MAC addresses, so changing source IP address for txonly-multi-flow can have negative performance implications for net/gve when using testpmd. This patch updates txonly multiflow mode to modify source ports instead of source IP addresses. The change can be tested with the following command: dpdk-testpmd -- --forward-mode=txonly --txonly-multi-flow \ --tx-ip=, Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta --- app/test-pmd/txonly.c | 39 +++++++++++++++++++++++---------------- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index b3d6873104..f79e0e5d0b 100644 --- a/app/test-pmd/txonly.c +++ b/app/test-pmd/txonly.c @@ -56,7 +56,7 @@ uint32_t tx_ip_dst_addr = (198U << 24) | (18 << 16) | (0 << 8) | 2; #define IP_DEFTTL 64 /* from RFC 1340. */ static struct rte_ipv4_hdr pkt_ip_hdr; /**< IP header of transmitted packets. */ -RTE_DEFINE_PER_LCORE(uint8_t, _ip_var); /**< IP address variation */ +RTE_DEFINE_PER_LCORE(uint8_t, _src_var); /**< Source port variation */ static struct rte_udp_hdr pkt_udp_hdr; /**< UDP header of tx packets. */ static uint64_t timestamp_mask; /**< Timestamp dynamic flag mask */ @@ -230,28 +230,35 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp, copy_buf_to_pkt(eth_hdr, sizeof(*eth_hdr), pkt, 0); copy_buf_to_pkt(&pkt_ip_hdr, sizeof(pkt_ip_hdr), pkt, sizeof(struct rte_ether_hdr)); + copy_buf_to_pkt(&pkt_udp_hdr, sizeof(pkt_udp_hdr), pkt, + sizeof(struct rte_ether_hdr) + + sizeof(struct rte_ipv4_hdr)); if (txonly_multi_flow) { - uint8_t ip_var = RTE_PER_LCORE(_ip_var); - struct rte_ipv4_hdr *ip_hdr; - uint32_t addr; + uint16_t src_var = RTE_PER_LCORE(_src_var); + struct rte_udp_hdr *udp_hdr; + uint16_t port; - ip_hdr = rte_pktmbuf_mtod_offset(pkt, - struct rte_ipv4_hdr *, - sizeof(struct rte_ether_hdr)); + udp_hdr = rte_pktmbuf_mtod_offset(pkt, + struct rte_udp_hdr *, + sizeof(struct rte_ether_hdr) + + sizeof(struct rte_ipv4_hdr)); /* - * Generate multiple flows by varying IP src addr. This - * enables packets are well distributed by RSS in + * Generate multiple flows by varying UDP source port. + * This enables packets are well distributed by RSS in * receiver side if any and txonly mode can be a decent * packet generator for developer's quick performance * regression test. + * + * Only ports in the range 49152 (0xC000) and 65535 (0xFFFF) + * will be used, with the least significant byte representing + * the lcore ID. As such, the most significant byte will cycle + * through 0xC0 and 0xFF. */ - addr = (tx_ip_dst_addr | (ip_var++ << 8)) + rte_lcore_id(); - ip_hdr->src_addr = rte_cpu_to_be_32(addr); - RTE_PER_LCORE(_ip_var) = ip_var; + port = ((((src_var++) % (0xFF - 0xC0) + 0xC0) & 0xFF) << 8) + + rte_lcore_id(); + udp_hdr->src_port = rte_cpu_to_be_16(port); + RTE_PER_LCORE(_src_var) = src_var; } - copy_buf_to_pkt(&pkt_udp_hdr, sizeof(pkt_udp_hdr), pkt, - sizeof(struct rte_ether_hdr) + - sizeof(struct rte_ipv4_hdr)); if (unlikely(tx_pkt_split == TX_PKT_SPLIT_RND) || txonly_multi_flow) update_pkt_header(pkt, pkt_len); @@ -393,7 +400,7 @@ pkt_burst_transmit(struct fwd_stream *fs) nb_tx = common_fwd_stream_transmit(fs, pkts_burst, nb_pkt); if (txonly_multi_flow) - RTE_PER_LCORE(_ip_var) -= nb_pkt - nb_tx; + RTE_PER_LCORE(_src_var) -= nb_pkt - nb_tx; if (unlikely(nb_tx < nb_pkt)) { if (verbose_level > 0 && fs->fwd_dropped == 0) -- 2.40.0.634.g4ca3ef3211-goog