From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A24BC429DD; Mon, 24 Apr 2023 18:23:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33D8041138; Mon, 24 Apr 2023 18:23:52 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 8DC87410ED for ; Mon, 24 Apr 2023 18:23:50 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-63b60365f53so5949795b3a.0 for ; Mon, 24 Apr 2023 09:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1682353429; x=1684945429; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=3/yxSw5B+eyIrNIpFodqycw8XuFK6mVBSnpTO8hAUec=; b=Eq6YPAWu/cJR3JnXWxYnzhkRD/b8aFQPBukStIO+CM2cs90284nikIf6GzKDMftkqT UPYSLR98lyMUD6rxjxYWR1VCusopNlsModhsibKPQNMR2hz/TYKKZiqOMoeFHjqxoWq1 3i9bVDSuVQQjzIsbSBrBJ2VW4XCW7wRnaC9QhWLLAK20iuttHgu0KY4LNS9RpfgoJ397 1MBBhjIppgce+DWScueop/XUi/M/dnDjr9UYsL3zg2qWRHqhM8O/oH8BuhHp2Afv6MST bW9ltR0w4GLodU34mu6Av+Ejm2FK5TUiC2CHfYfdgOHrk16gWxd1xJlVmOsaFrDmUNO6 w6jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682353429; x=1684945429; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3/yxSw5B+eyIrNIpFodqycw8XuFK6mVBSnpTO8hAUec=; b=ZZhDWkGVZ8gerTCBUYYCEZE6gOyvlSA80tilksqICDG6wXPAHp6v8XoT8kdhapIF58 2S02TEWzYcq53BQ7CQ9r8fQ75SJTqt/dgKtStnBN/2EdnyCTq3IW1cB2US1bX5ihjxVI +BMOS132y6ir8qShWw/Hj/b9SUqwP1COVBhcrErERSUn+XgrEdu0BwQnhQjSvz3YEQ1e JKEqg1brrz7Z9vFCeNCcF4hSQzGygS+Af2v0ppRYOnDihn7qDDk/57sDRtx1wVbHlQS5 nxQ7olEM6eY3M097VNFzDr0V4RIO96j42rnsVUu8TkNWFSM/voAGxJ1DVIBCOoJjxCBR Hnnw== X-Gm-Message-State: AAQBX9dORCf2NrDkHcGKOQ/a9kMZbFm0yX/B63YJIl5Trv7NihHGZ933 2JKAVZumKqhgjOwmkxtvfM6ZOQ== X-Google-Smtp-Source: AKy350bJt3np9vXloLQp8uEgl5g2W7GJki67I+tf9591+VoMb4beskNhDfjh2YGB657eaMWgxnqgvg== X-Received: by 2002:a05:6a00:1141:b0:63d:2d8c:7fd5 with SMTP id b1-20020a056a00114100b0063d2d8c7fd5mr18704887pfm.12.1682353429664; Mon, 24 Apr 2023 09:23:49 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x28-20020a056a00189c00b0063b6cccd5dcsm7673386pfh.194.2023.04.24.09.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Apr 2023 09:23:49 -0700 (PDT) Date: Mon, 24 Apr 2023 09:23:48 -0700 From: Stephen Hemminger To: Qi Zhang Cc: beilei.xing@intel.com, dev@dpdk.org Subject: Re: [PATCH] common/idpf: remove unnecessary compile option Message-ID: <20230424092348.726583b1@hermes.local> In-Reply-To: <20230424224700.997910-1-qi.z.zhang@intel.com> References: <20230424224700.997910-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 24 Apr 2023 18:47:00 -0400 Qi Zhang wrote: > Remove compile option "__KERNEL" which should not be considered in > DPDK. Also only #include in idpf_osdep.h. > > Signed-off-by: Qi Zhang This will cause some warnings in DPDK build depending on compiler version and flags. You need to leave the fallthrough comment or use one of the other fallthrough annotations.