From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F34B429DF; Mon, 24 Apr 2023 19:41:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3A60410ED; Mon, 24 Apr 2023 19:41:54 +0200 (CEST) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id 71C5F4013F for ; Mon, 24 Apr 2023 19:41:53 +0200 (CEST) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-518d325b8a2so4902740a12.0 for ; Mon, 24 Apr 2023 10:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1682358112; x=1684950112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Ccy7U9nO/YxXn0/bS0C9po3Da5Si+vDfgWYcTVk/HTA=; b=Me9vYY6HY2POuN0GPxCuFC1LZ5nasYaWWlAMStFYvTWwckZOleUKwACp+gwE4KGmyh t4NIBu5dHLLYeFXOs9l4k71Nj7YNiIVXhtwjqk+sMZE7+Vr97GdlZ6Daixtjmj3Gaw5h hJhaSMD1BNk0CcjSSvNmluR40h+/EDR2m5PfdrlakXS40gWqMBHC9oucmzI2/ZuS3YoC UvO6N+LEbfUHJnESiXEv6rXvinmp9t/edb1nD3TyO9fTuRTiXmoAsZ4x9Ro/kPxu9WZm 0p5KT5M36p844EnJQgT/lwLUa+CBnnX2sBPFCnpG0N016S/U0SJ5EOUbuArSKDh6sDWb oSlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682358112; x=1684950112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ccy7U9nO/YxXn0/bS0C9po3Da5Si+vDfgWYcTVk/HTA=; b=DClYze0ZyRRkjwIQOWNnq0rMospRSCqBtQ3GmdZZ19xpeMayjJUrch4Cv25We4Gyo+ gkTglY8U6onPELcHoFXo9pjPfEKF6FgfaJT8DNxmhHNVdvKPONemD4EWSG46G6nqetSW z1EkmpIV+zbPNQrb0SJci/QILYvGvlKtILLe0EyAW3prHZtEdxWgbCBv5Rdd64vhZuA8 B2btU12m6hmcZYwwLHid1ZtdsUWB4i4Ec9fkeT5EeFXjg8SDhw3W0kJiPUEBxI3a8G8i 8sNsMM9HAEtuT4MGOByBVJPVMVYRo0ZewawiIxK/qTK1NyfqOb2GPoKpha7/kQQ1cGP1 wThw== X-Gm-Message-State: AAQBX9d80KL1zryB7nqjuQ/F5qNeP1NnxzD58jGEiIVf4ku3xI2p+O5p mBhxtcl4rBvWydZy9dnzrY/2JQ== X-Google-Smtp-Source: AKy350ZJK86ZQ9rF2YI6ecW4IG+LewXOzHIDKz2C1/+Va2+vIWnupdrYt/Zg/UKIBe/bBCXfIoWqjQ== X-Received: by 2002:a17:902:d4c8:b0:1a6:71b1:a0b9 with SMTP id o8-20020a170902d4c800b001a671b1a0b9mr17975967plg.47.1682358112355; Mon, 24 Apr 2023 10:41:52 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id 6-20020a170902c24600b001a19f3a661esm6870583plg.138.2023.04.24.10.41.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Apr 2023 10:41:49 -0700 (PDT) Date: Mon, 24 Apr 2023 10:41:46 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: Qi Zhang , beilei.xing@intel.com, dev@dpdk.org Subject: Re: [PATCH] common/idpf: remove unnecessary compile option Message-ID: <20230424104146.3d7eedec@hermes.local> In-Reply-To: <20230424172919.GA23909@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230424224700.997910-1-qi.z.zhang@intel.com> <20230424092348.726583b1@hermes.local> <20230424172919.GA23909@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 24 Apr 2023 10:29:19 -0700 Tyler Retzlaff wrote: > On Mon, Apr 24, 2023 at 09:23:48AM -0700, Stephen Hemminger wrote: > > On Mon, 24 Apr 2023 18:47:00 -0400 > > Qi Zhang wrote: > > > > > Remove compile option "__KERNEL" which should not be considered in > > > DPDK. Also only #include in idpf_osdep.h. > > > > > > Signed-off-by: Qi Zhang > > > > This will cause some warnings in DPDK build depending on compiler > > version and flags. You need to leave the fallthrough comment or > > use one of the other fallthrough annotations. > > if there are variations of annotating fallthrough i would not object to > a macro for it being exposed from rte_common.h > > full disclosure it would let me use the equivalent that are provided > with windows and windows toolchains. Yes having something like __rte_fallthrough would help. Wouldn't help code that is trying to always work in kernel, DPDK or other places. Both Gcc and clang use statement attributes and C++ has [[fallthrough]] https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html https://clang.llvm.org/docs/AttributeReference.html#fallthrough