DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Christensen <drc@linux.vnet.ibm.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] net/tap: Set locally administered bit with a fixed MAC address
Date: Tue, 25 Apr 2023 17:39:59 -0700	[thread overview]
Message-ID: <20230425173959.3cb70f20@hermes.local> (raw)
In-Reply-To: <20230425205806.776057-1-drc@linux.vnet.ibm.com>

On Tue, 25 Apr 2023 16:58:06 -0400
David Christensen <drc@linux.vnet.ibm.com> wrote:

> When the tap driver is loaded and the user selects the optional
> "mac=fixed" setting, the tap driver incorrectly uses a globally
> unique EUI-48 identifier (as documented in RFC 7042) of
> 00:64:74:61:70:<iface_idx>. Since this is a locally generated ID,
> the Local bit in the MAC address should be set to 1, resulting in
> the new address 02:64:74:61:70:<iface_idx>.
> 
> Bugzilla ID: 1198
> 
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>

Acked-by: Stephen Hemminger <stephen@networkplumber.org>


  reply	other threads:[~2023-04-26  0:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 20:58 David Christensen
2023-04-26  0:39 ` Stephen Hemminger [this message]
2023-04-26 15:58   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230425173959.3cb70f20@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).