From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F4D6429D4; Wed, 26 Apr 2023 02:40:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 077EC4111C; Wed, 26 Apr 2023 02:40:05 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 84924410DC for ; Wed, 26 Apr 2023 02:40:03 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1a920d4842bso49665645ad.2 for ; Tue, 25 Apr 2023 17:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1682469602; x=1685061602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=QnZ8sZ6vJ7Wbl7LX8R6jvJ9k40ZqkrSELU6pBhpTFsQ=; b=BHr/XFYTtNchSmUL/ryW8st4ROaak8oAvc0jrW4ATAbuRPqXFpz5LPwZsvuIWaoZxY aoc27fTR5zcGst6qRco5daoGqSoSAVErIGPkw4dGZc3PEaB7SpejXAufCm54dsqxbs9Q Ezxlpt30EaOFzQrKvH4VfkRw5KGRe3sqomTCKl8vLf33HGpODKhE4KG7v/41RGeoFeDC KtFqxRdJ1DZY/HetfJxX3ue5cz9Ss6jVyLv1IXEuppeYjLf4s5pizvbwQEGf0yXyOI/V evlj/cCZczskPRzngWh1atgiXfwlZgL9PtWyRpXkcHeu7ivnXwGu3w1/rcgZgBmeU9eF mA0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682469602; x=1685061602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QnZ8sZ6vJ7Wbl7LX8R6jvJ9k40ZqkrSELU6pBhpTFsQ=; b=QCv17q93w4crgucJ9QRkffHbDxfCBs7gtFoKR1WbRjbZjHcZftbdbH+xFvqjkIL5lS cxk7NwGkePghowW3xf8Qoofpz3fNqIfluK6UeHZNT5D41QVNzNpKNEeV6Xk6ZV1EMGu/ qKFvoiqEPGg/ZMqZZ5qI+XVLHngUoI5/ktMBbiYfJKMZ1IPoFgGrBWsorALbFZx+LN+e n9lAnlS6UOU+QPr60QEg5VJfOJ79nnb3n6cjse2GS+Zra7rQHfN5fTGxyuVrGXdWE+bq O9zl+MUrv57v/8UWZfepSt9o0POU/tkx83KW+QCdBA/WFQE+M2CmObkrsGUUetWDnXyz 5Dbg== X-Gm-Message-State: AAQBX9cF7lcuEgRxxZPeHkSHVzMzeFCSNh2ZvXr2aYoHtV7BvQrhnfd9 ENBEcVI5SJbf/79nBZRHj25u+w== X-Google-Smtp-Source: AKy350Yqy3cMqJ+u4PrPGGDIogxql9Na98r0IDqJPPTrqdlMeHYlwi85hsOmKHsEOQrQ9UPSeG/OGg== X-Received: by 2002:a17:902:f68e:b0:1a1:f0ad:8657 with SMTP id l14-20020a170902f68e00b001a1f0ad8657mr26228548plg.37.1682469602501; Tue, 25 Apr 2023 17:40:02 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id jf15-20020a170903268f00b001a076568da9sm8746406plb.216.2023.04.25.17.40.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 17:40:02 -0700 (PDT) Date: Tue, 25 Apr 2023 17:39:59 -0700 From: Stephen Hemminger To: David Christensen Cc: dev@dpdk.org Subject: Re: [PATCH] net/tap: Set locally administered bit with a fixed MAC address Message-ID: <20230425173959.3cb70f20@hermes.local> In-Reply-To: <20230425205806.776057-1-drc@linux.vnet.ibm.com> References: <20230425205806.776057-1-drc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 25 Apr 2023 16:58:06 -0400 David Christensen wrote: > When the tap driver is loaded and the user selects the optional > "mac=fixed" setting, the tap driver incorrectly uses a globally > unique EUI-48 identifier (as documented in RFC 7042) of > 00:64:74:61:70:. Since this is a locally generated ID, > the Local bit in the MAC address should be set to 1, resulting in > the new address 02:64:74:61:70:. > > Bugzilla ID: 1198 > > Signed-off-by: David Christensen Acked-by: Stephen Hemminger