From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A14742A12; Fri, 28 Apr 2023 09:27:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE2D042F8E; Fri, 28 Apr 2023 09:26:59 +0200 (CEST) Received: from EX-PRD-EDGE01.vmware.com (EX-PRD-EDGE01.vmware.com [208.91.3.33]) by mails.dpdk.org (Postfix) with ESMTP id DB87D42DA2 for ; Fri, 28 Apr 2023 09:11:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=s1024; d=vmware.com; h=from:to:cc:subject:date:message-id:in-reply-to:mime-version: content-type; bh=am+89PS/HJGdtII8YmqMh6hZAID3jtRz4wlveSWbYJU=; b=I5qVARTcOrIevFiJ6kWwtwjoQvCSFpbOgRYrVoQZIdZo7vWozMSF84IJgD3aVt KXEam2zH1I58bbL51qs6b0+PFNS1fdwqKL8OJ40zXVeRCCkluPug3+D+JKhF/R qX2zWcgGMmhDaEicYWGLBw4/yQ4udLWThnGFTL2Yx7LJcbI= Received: from sc9-mailhost1.vmware.com (10.113.161.71) by EX-PRD-EDGE01.vmware.com (10.188.245.6) with Microsoft SMTP Server id 15.1.2375.34; Fri, 28 Apr 2023 00:10:55 -0700 Received: from htb-1n-eng-dhcp122.eng.vmware.com (unknown [10.20.114.216]) by sc9-mailhost1.vmware.com (Postfix) with ESMTP id BDA5720384; Fri, 28 Apr 2023 00:10:58 -0700 (PDT) Received: by htb-1n-eng-dhcp122.eng.vmware.com (Postfix, from userid 0) id B8500A83B6; Fri, 28 Apr 2023 00:10:58 -0700 (PDT) From: Ronak Doshi To: Jochen Behrens CC: , Ronak Doshi Subject: [PATCH v3 next 5/7] net/vmxnet3: limit number of TXDs used for TSO packet Date: Fri, 28 Apr 2023 00:10:52 -0700 Message-ID: <20230428071055.362-6-doshir@vmware.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20230428071055.362-1-doshir@vmware.com> References: <20230428071055.362-1-doshir@vmware.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: None (EX-PRD-EDGE01.vmware.com: doshir@vmware.com does not designate permitted sender hosts) X-Mailman-Approved-At: Fri, 28 Apr 2023 09:26:51 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently, vmxnet3 does not have a limit on number of descriptors used for a TSO packet. However, with UPT, for hardware performance reasons, this patch limits the number of transmit descriptors to 24 for a TSO packet. Signed-off-by: Ronak Doshi Acked-by: Jochen Behrens --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 2 ++ drivers/net/vmxnet3/vmxnet3_rxtx.c | 18 ++++++++++++++---- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h index d8cc295b08..24c235876e 100644 --- a/drivers/net/vmxnet3/base/vmxnet3_defs.h +++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h @@ -419,6 +419,8 @@ typedef union Vmxnet3_GenericDesc { /* max # of tx descs for a non-tso pkt */ #define VMXNET3_MAX_TXD_PER_PKT 16 +/* max # of tx descs for a tso pkt */ +#define VMXNET3_MAX_TSO_TXD_PER_PKT 24 /* Max size of a single rx buffer */ #define VMXNET3_MAX_RX_BUF_SIZE ((1 << 14) - 1) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index e31878ecab..7bbae4177e 100644 --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c @@ -364,6 +364,14 @@ vmxnet3_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, rte_errno = EINVAL; return i; } + /* TSO packet cannot occupy more than + * VMXNET3_MAX_TSO_TXD_PER_PKT TX descriptors. + */ + if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) != 0 && + m->nb_segs > VMXNET3_MAX_TSO_TXD_PER_PKT) { + rte_errno = EINVAL; + return i; + } /* check that only supported TX offloads are requested. */ if ((ol_flags & VMXNET3_TX_OFFLOAD_NOTSUP_MASK) != 0 || @@ -444,10 +452,12 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, continue; } - /* Drop non-TSO packet that is excessively fragmented */ - if (unlikely(!tso && count > VMXNET3_MAX_TXD_PER_PKT)) { - PMD_TX_LOG(ERR, "Non-TSO packet cannot occupy more than %d tx " - "descriptors. Packet dropped.", VMXNET3_MAX_TXD_PER_PKT); + /* Drop non-TSO or TSO packet that is excessively fragmented */ + if (unlikely((!tso && count > VMXNET3_MAX_TXD_PER_PKT) || + (tso && count > VMXNET3_MAX_TSO_TXD_PER_PKT))) { + PMD_TX_LOG(ERR, "Non-TSO or TSO packet cannot occupy more than " + "%d or %d tx descriptors respectively. Packet dropped.", + VMXNET3_MAX_TXD_PER_PKT, VMXNET3_MAX_TSO_TXD_PER_PKT); txq->stats.drop_too_many_segs++; txq->stats.drop_total++; rte_pktmbuf_free(txm); -- 2.11.0