From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F6F242AD6; Thu, 11 May 2023 17:39:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A64D42DAE; Thu, 11 May 2023 17:39:16 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 1F2C940DF6 for ; Thu, 11 May 2023 17:39:15 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1aaea43def7so61026585ad.2 for ; Thu, 11 May 2023 08:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1683819554; x=1686411554; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2acYHRNtIOmviNeBlS1sETmSib0EgxVwmI5jGmnirtg=; b=Rhlcqu2smY7ThXPPQkLg06420ZkvEQRyWhX/apow10KlSag8GQkOhuKD1FRlYVpfsh JgGR/eaX5hfQ4KNbRMcMvjOIPssodmvwx4qgvxnY3BVScToT2MDuKwxEiFrBZqlEu2wg djqOszYzgzgRbmOxkjqYYjJeAdVJDqvLCT9V40Ir8l5GdvFDgYfsI3b69tTBFW+jNUJd FPEGW9WcU9fChuy8V/5GyYSytBGvxXlasnXWXESA79oq/xjsm0Wke//2mMHgryw72J1E Fp0hVEp/Ai02ZKeuTjyiRlzmHjVZTkvQPaAR2myPxmda14RzsS3SyxvvbZ30VF9f28QZ QM/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683819554; x=1686411554; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2acYHRNtIOmviNeBlS1sETmSib0EgxVwmI5jGmnirtg=; b=ctmRG+PJFJ0HAUDaiATnPtd2IiAdXBDoFj4f8MC0/xF9UklCuyZpyse2NrJ7vyKPB6 5GzpLMOV79uoWv6/a1v9XANNDWdMR9cT2JGWLwL9uSO0x73k17bjjC4FgbgGm6728+V7 QgmTPK+C+9dcc2sy0Q8+gvRUeDz7WiytkFJzQCUo0m2PXJkl7es3K8hcKRBMMe0tVb04 vPCwdsFOp6bVKJims5VDL3ZTUtOSJj+5i5JgZqLMD8S/hnlM/p8O0Rzuyr/CCKJbh/BP iOlpkL9oFYQjv84jNdhfCps01047sMJl4Flhsb9DDjmeYhjlvZJuM68mzqs9ZX1YyQld OdTA== X-Gm-Message-State: AC+VfDwfkiFCXCSRtuQNR16Q+FINT1rFjfA3NpeGUI01C2cliTnp++C4 6OSRlylYgZOcC71qxbneC5o+i0ofFFm97PmCoZo2Rg== X-Google-Smtp-Source: ACHHUZ7XFbY/tvz71UK5Ozh/NCStTlxYAZqzUjZp3jah6/NZN52OWF42CvfVZNsn136CY7lcQnaQfw== X-Received: by 2002:a17:902:dace:b0:1ac:6e1f:d1bd with SMTP id q14-20020a170902dace00b001ac6e1fd1bdmr20988889plx.19.1683819554347; Thu, 11 May 2023 08:39:14 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id 95-20020a17090a0fe800b0024de3dff70esm21812578pjz.56.2023.05.11.08.39.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 08:39:14 -0700 (PDT) Date: Thu, 11 May 2023 08:39:12 -0700 From: Stephen Hemminger To: Trevor Tao Cc: "thomas@monjalon.net" , "dev@dpdk.org" Subject: Re: [PATCH] examples/l3fwd: relax the RSS/Offload requirement Message-ID: <20230511083912.439d8e65@hermes.local> In-Reply-To: References: <20230511080612.126034-1-trevor.tao@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 11 May 2023 09:33:35 +0000 Trevor Tao wrote: > + /* relax the rx rss requirement */ > + if (dev_info.max_rx_queues == 1 || !local_port_conf.rx_adv_conf.rss_conf.rss_hf) { > + printf("warning: modified the rx mq_mode to RTE_ETH_MQ_RX_NONE base on" > + " device capability\n"); > local_port_conf.rxmode.mq_mode = RTE_ETH_MQ_RX_NONE; > + } There is no point in doing RSS if only a single queue. Therefore remove the !local_port.conf portion of the expression. And since this is normal, no printf is needed.