From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1656B42B1A; Tue, 16 May 2023 03:28:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79ED942B8E; Tue, 16 May 2023 03:28:43 +0200 (CEST) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id A4C9740A7A for ; Tue, 16 May 2023 03:28:41 +0200 (CEST) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-51b0f9d7d70so12446436a12.1 for ; Mon, 15 May 2023 18:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684200520; x=1686792520; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1Cqi3p1Yu9n/pNUcXOJYAKWD/O5T0C7KBq/mfUmRYZ8=; b=1xQrOSAq0XZWhdm7fYMzaiakfHhz7kuUPujdqCbHPhDcOIYiA6rTPGH6YNz2CVA8D2 uOaJ9WZqnzTEAVMFzYXN57wsWzt7DJs9YCaEW5hzwXs0rtJ75G5FVxEHysRxe2AXK3I9 jpQo/5J9X+/CfcwGW1Td5525lVLfhtLnoRQDnvWOerW7fK3zAWTsAwFOiX/5sc9fVrbe JPLTPw6qeISz91MwL0Wq1B9HG7oHT7BDZKcKp6renr9h3lZ613h+U1Y/StFy6+9jg0t7 PJfmHmP7CvYgOIzTfYOOgtKeWPLUFGX5mwVKHISw04UXTIAjac51NPhnmTqyNSuUgHDw knTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684200520; x=1686792520; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1Cqi3p1Yu9n/pNUcXOJYAKWD/O5T0C7KBq/mfUmRYZ8=; b=V7GlFVVcUrxizn5vz6KtyRU91+Cr0XIbdkcbWW5BNY6rFLDYbU47EvWelDeHsseVkR RPm7SLZD2CpJ6WN9AeCi/YAJgPOgDFqdeSJpR3tc3VBnkHXckIwoPvuEXoBeW7ZMzlLc ajJH1qzHlTOuJB2aMN+nNPIvHhnpCHxLR+vb6vEbmV4c6bwO78o6O/rkqOFhyhOIVUw4 JP6SYQwE2BcgFhJgYItQg3xnAnQFO0jbn7ocdoY8ugFib5CZ/3fQhEHLoPFNm1VnbKxv 7al8H63JoHZNtcWOtRFvudNSws46StThSjVzOCUDJy+dMrRlfmcUqk1cdgz5mpoW0vng x7Vg== X-Gm-Message-State: AC+VfDyBozmqk3tNulZsKuG19gwgOP8BtUFjfe3DaDBvNDa7hJdGX281 RzT0VoojWIq3sZzKB5pmGGkB0A== X-Google-Smtp-Source: ACHHUZ7/uzrTIi/Qdqqno+1aUX5iIwCpnm6NiQJwEUr8GQts/8nHkWXYB35PVH42R5Mnu3UpzGyQTw== X-Received: by 2002:a05:6a20:430a:b0:101:a435:a38 with SMTP id h10-20020a056a20430a00b00101a4350a38mr26521973pzk.57.1684200520662; Mon, 15 May 2023 18:28:40 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id d3-20020a17090a8d8300b0024dee5cbe29sm253554pjo.27.2023.05.15.18.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 18:28:40 -0700 (PDT) Date: Mon, 15 May 2023 18:28:38 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: David Christensen , dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le Message-ID: <20230515182838.08e49a7c@hermes.local> In-Reply-To: References: <20230322212439.524725-1-drc@linux.vnet.ibm.com> <20230323170145.129901-1-drc@linux.vnet.ibm.com> <165a233b-b41b-3a65-1866-5b7c94993b40@amd.com> <20230515162032.36a4f3ec@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 16 May 2023 00:35:56 +0100 Ferruh Yigit wrote: > Yes only some scripts and possible applications that hotplug tap > interface with hardcoded parameters may impacted, don't know how big is > this amount but this ends up breaking something that was working before > upgrading DPDK for them. > > And I believe the motivation is weak to break the behavior. > > Won't it be better to update 'rte_ether_unformat_addr()' to accept more > flexible syntax, and use it? Is there any disadvantage of this approach? It is already more flexible than the standard ether_aton().