DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Yasin CANER <yasinncaner@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2] lib/kni : coding style is fixed
Date: Tue, 16 May 2023 08:16:11 -0700	[thread overview]
Message-ID: <20230516081611.13644b82@hermes.local> (raw)
In-Reply-To: <20230516110359.479441-1-yasinncaner@gmail.com>

On Tue, 16 May 2023 11:03:59 +0000
Yasin CANER <yasinncaner@gmail.com> wrote:

> +	/* First, getting allocation count from alloc_q. alloc_q is allocated in this function*/ 
> +	/* and/or kni_alloc function from mempool.*/
> +	/* If alloc_q is completely removed, it shall be allocated again.*/

If you send another version of this patch. It would be good to follow the style of multi-line comment.
	/* First, getting allocation count from alloc_q. alloc_q is allocated in this function
	 *  and/or kni_alloc function from mempool.
	 * If alloc_q is completely removed, it shall be allocated again.
	 */



  reply	other threads:[~2023-05-16 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 10:48 [PATCH] lib/kni : fix memory-leak on rte_kni_rx_burst Yasin CANER
2023-05-16 11:03 ` [PATCH v2] lib/kni : coding style is fixed Yasin CANER
2023-05-16 15:16   ` Stephen Hemminger [this message]
2023-05-17 18:25 ` [PATCH] lib/kni : fix memory-leak on rte_kni_rx_burst Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230516081611.13644b82@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=yasinncaner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).