From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4D4BA42B2C;
	Wed, 17 May 2023 18:17:39 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E068A42DA2;
	Wed, 17 May 2023 18:16:28 +0200 (CEST)
Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com
 [209.85.215.176])
 by mails.dpdk.org (Postfix) with ESMTP id 7B05B42D6D
 for <dev@dpdk.org>; Wed, 17 May 2023 18:16:23 +0200 (CEST)
Received: by mail-pg1-f176.google.com with SMTP id
 41be03b00d2f7-5307502146aso637604a12.1
 for <dev@dpdk.org>; Wed, 17 May 2023 09:16:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684340182;
 x=1686932182; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=2ExCDqThjCDlZxRs/cZRIJvP1uteJ/8ZUE6rrQ56gqA=;
 b=ZJSmGWFYqlFnRUN5jchkeAbhW4FcZeL9rppQxgz+kFkgGFrcI6UV9WdzEyOjtqm4tJ
 ilo5x/FYbjTOOtSvQZmr9hfOYazQEZubCpuM1f+vlPnXe5H0hYJBtzwdwAz4cyWgmtAx
 zxdtMt2xcyoXTyuhy7Qk8qGa7Y8EdIgPj0cEGNLNGDPiUE8d4YzbXJvdtlLu2uqchqpv
 CFSjR90dlaD4vnztSUtd+09yZjajC/97KE6O56tqlP96Q1sX3IGIMPGiqlXr9z4JAPyK
 6yrY05EL0Uh9xakxfzKrXTLWy7cZS8A9ngBjU05KaA6dzarfHojpqngyhsw1LpkciJo3
 mstQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1684340182; x=1686932182;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=2ExCDqThjCDlZxRs/cZRIJvP1uteJ/8ZUE6rrQ56gqA=;
 b=GQccQv8GqspYitdKRu8URXcg6svsM/LMg5LMdabqsnD8gaehUAhEEK0H5vTxJlRrBU
 JnERzKxB8ulnYDT8AyLZq4WEA5fFH694rnjpvoMx+c2mSyeSz1HBfeOQBRzRxIjoPXCI
 hS7HBmSWvzGUw6DxePU5y06F842wOeGMx+kpmny2fZEH63L+cpyJzlt2/MoT4aa4SzVR
 qcuIq625gif7fU8+QZribMKeEw3mJDVl3vsgohZADiRnQ+V8yYU2fX4lt+SsMiLMpIkC
 yKIowLhUu/De3rpTCfeLLLDZWl6CPvrJi0seYySjmoyRF61kJtssAo2P/8GFwDJhMvYs
 No6Q==
X-Gm-Message-State: AC+VfDyb7X/ozhsLBBA15QvZtavrfWkPUE1NoPo+n0PX5Itsy3O4xJAB
 12s1kTg2piesFJ/1xZZ9mCDv6CcVq+Jk9rEXFDMPmw==
X-Google-Smtp-Source: ACHHUZ7uO8eKIA6m+gGUXLfTwh3z4iX7K5q6sJpxlyFaumFj1UJ6kKDZqhNHmpO40H3KGTH+nnABPA==
X-Received: by 2002:a05:6a20:6a2a:b0:f6:d4d:2d with SMTP id
 p42-20020a056a206a2a00b000f60d4d002dmr47282448pzk.31.1684340182473; 
 Wed, 17 May 2023 09:16:22 -0700 (PDT)
Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])
 by smtp.gmail.com with ESMTPSA id
 h5-20020a62b405000000b0063f33e216dasm15793009pfn.96.2023.05.17.09.16.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 17 May 2023 09:16:22 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 Rasesh Mody <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>
Subject: [PATCH 14/20] net/bnx2x: remove reference to sanity
Date: Wed, 17 May 2023 09:15:57 -0700
Message-Id: <20230517161603.117728-15-stephen@networkplumber.org>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20230517161603.117728-1-stephen@networkplumber.org>
References: <20230517161603.117728-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Replace "sanity check"

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnx2x/bnx2x.c       | 2 +-
 drivers/net/bnx2x/bnx2x_stats.c | 8 ++++----
 drivers/net/bnx2x/ecore_sp.c    | 2 +-
 drivers/net/bnx2x/elink.c       | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 29c16bb207c7..0d2dc2d3b3fa 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -7821,7 +7821,7 @@ static int bnx2x_check_valid_mf_cfg(struct bnx2x_softc *sc)
 	uint32_t ovlan2;
 	uint8_t i, j;
 
-	/* various MF mode sanity checks... */
+	/* various MF mode checks... */
 
 	if (mf_info->mf_config[SC_VN(sc)] & FUNC_MF_CFG_FUNC_HIDE) {
 		PMD_DRV_LOG(NOTICE, sc,
diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c
index c07b01510a06..86d90679ac0a 100644
--- a/drivers/net/bnx2x/bnx2x_stats.c
+++ b/drivers/net/bnx2x/bnx2x_stats.c
@@ -187,7 +187,7 @@ bnx2x_stats_pmf_update(struct bnx2x_softc *sc)
 		 */
 		return;
 	}
-	/* sanity */
+	/* input valid? */
 	if (!sc->port.pmf || !sc->port.port_stx) {
 		PMD_DRV_LOG(ERR, sc, "BUG!");
 		return;
@@ -237,7 +237,7 @@ bnx2x_port_stats_init(struct bnx2x_softc *sc)
     uint32_t mac_addr;
     uint32_t *stats_comp = BNX2X_SP(sc, stats_comp);
 
-    /* sanity */
+    /* input valid? */
     if (!sc->link_vars.link_up || !sc->port.pmf) {
 	PMD_DRV_LOG(ERR, sc, "BUG!");
 	return;
@@ -461,7 +461,7 @@ bnx2x_func_stats_init(struct bnx2x_softc *sc)
     struct dmae_command *dmae = &sc->stats_dmae;
     uint32_t *stats_comp = BNX2X_SP(sc, stats_comp);
 
-    /* sanity */
+    /* input valid? */
     if (!sc->func_stx) {
 	PMD_DRV_LOG(ERR, sc, "BUG!");
 	return;
@@ -1301,7 +1301,7 @@ bnx2x_port_stats_base_init(struct bnx2x_softc *sc)
     struct dmae_command *dmae;
     uint32_t *stats_comp = BNX2X_SP(sc, stats_comp);
 
-    /* sanity */
+    /* input valid? */
     if (!sc->port.pmf || !sc->port.port_stx) {
 	PMD_DRV_LOG(ERR, sc, "BUG!");
 	return;
diff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c
index c6c3857778f7..158205266f62 100644
--- a/drivers/net/bnx2x/ecore_sp.c
+++ b/drivers/net/bnx2x/ecore_sp.c
@@ -207,7 +207,7 @@ static int ecore_exe_queue_step(struct bnx2x_softc *sc,
 			break;
 	}
 
-	/* Sanity check */
+	/* Argument check */
 	if (!cur_len)
 		return ECORE_SUCCESS;
 
diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
index 43fbf04ece11..2b0236aac24e 100644
--- a/drivers/net/bnx2x/elink.c
+++ b/drivers/net/bnx2x/elink.c
@@ -1087,7 +1087,7 @@ static void elink_get_epio(struct bnx2x_softc *sc, uint32_t epio_pin,
 {
 	uint32_t epio_mask, gp_oenable;
 	*en = 0;
-	/* Sanity check */
+	/* Input check */
 	if (epio_pin > 31) {
 		ELINK_DEBUG_P1(sc, "Invalid EPIO pin %d to get", epio_pin);
 		return;
@@ -1104,7 +1104,7 @@ static void elink_set_epio(struct bnx2x_softc *sc, uint32_t epio_pin, uint32_t e
 {
 	uint32_t epio_mask, gp_output, gp_oenable;
 
-	/* Sanity check */
+	/* Input check */
 	if (epio_pin > 31) {
 		ELINK_DEBUG_P1(sc, "Invalid EPIO pin %d to set", epio_pin);
 		return;
-- 
2.39.2