From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5BCD42B73; Tue, 23 May 2023 23:30:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3244840A80; Tue, 23 May 2023 23:30:01 +0200 (CEST) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id 505C740689 for ; Tue, 23 May 2023 23:30:00 +0200 (CEST) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-25566708233so205652a91.0 for ; Tue, 23 May 2023 14:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684877399; x=1687469399; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hOjuf59gYizQODvhcxNWkJeSKZ62nrql9L5p9/mPocc=; b=fNK7SwozjLEevgY2szQQKfI6lUg1V2toraYCSRYobkY8dINJhaNwpTXt9GsoTZm9XP tOx788xGrXhix7epU95UPVb/VSeMjT8cHQANmIMC4tnUalPk+wBdoOQffYeOnb0ZBg6I meiLKXRsrM/yV1t7bJKhwUT0hxR1g51PcjXCnqGy0ADED6m1zGyuEu4OnCa5+IU7jGAd aHq+NM4hFCQcjG7QSPrMt5F41csD3fy0JAlELBihm/eLAirx9ht30VwbdVA8VABCfVAZ pRRLSBy9O3Cipdcpu7paO5P/X4Qpt+ofe2hUMP2oBAfI3PpUEyeZQI+6u6v4QLKynUrz lUrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684877399; x=1687469399; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hOjuf59gYizQODvhcxNWkJeSKZ62nrql9L5p9/mPocc=; b=HrqhVRQbpjNX6KkDFKmXKgghSvjtSHbjjQ1YLnbu3Nl4mmZbU39bq6Sv3k5QTh6T0v B5u9hsQdRBvzZ+fyghNrRfGHVSAAo5hdIna2gaPQ6vyuUeY+zJFVkqK3XWf0nzsVmpN+ T3+IBYaNwLtuSVS98D03DFw062qlUQtcjrEP3Q7r6BxcjcHu1SOLKE9IDaChJCD5Getk mmqmhdY4p0UL9MV/ON6VWFQn8dmYow2yBDfOODWy4TBBBCKvRb/YIGU7aPdqT9u64hwW ltEJWLOe03VH2GfJ14c3h+IqTouAHgviTfmi667h4ZPWBYsjSevukZcptI5hb+6U1L2F 3REg== X-Gm-Message-State: AC+VfDwZNlrgBfcpAuBeN1oN2x7JeP8Ug96YIkd5NP/ykFoGTQo69aFm Ef6aU40CqeAbNvDITVo1Kwho2g== X-Google-Smtp-Source: ACHHUZ70hvzi5hehktgkuz347zmAeiD6o7AExrhX6m2zZevTnt9aNSn3Gia0IOvxJ624VYJo+f8vOw== X-Received: by 2002:a17:90a:af89:b0:255:c061:9e5b with SMTP id w9-20020a17090aaf8900b00255c0619e5bmr1750338pjq.37.1684877399285; Tue, 23 May 2023 14:29:59 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id fh12-20020a17090b034c00b0024b6a90741esm5497pjb.49.2023.05.23.14.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 14:29:58 -0700 (PDT) Date: Tue, 23 May 2023 14:29:56 -0700 From: Stephen Hemminger To: Akhil Goyal Cc: , , , , , , , , , Subject: Re: [PATCH 02/13] security: add MACsec packet number threshold Message-ID: <20230523142956.2d9ce11a@hermes.local> In-Reply-To: <20230523194918.1940212-3-gakhil@marvell.com> References: <20220928124516.93050-5-gakhil@marvell.com> <20230523194918.1940212-1-gakhil@marvell.com> <20230523194918.1940212-3-gakhil@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 24 May 2023 01:19:07 +0530 Akhil Goyal wrote: > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > index c7a523b6d6..30bac4e25a 100644 > --- a/lib/security/rte_security.h > +++ b/lib/security/rte_security.h > @@ -399,6 +399,8 @@ struct rte_security_macsec_sa { > struct rte_security_macsec_sc { > /** Direction of SC */ > enum rte_security_macsec_direction dir; > + /** Packet number threshold */ > + uint64_t pn_threshold; > union { > struct { > /** SAs for each association number */ > @@ -407,8 +409,10 @@ struct rte_security_macsec_sc { > uint8_t sa_in_use[RTE_SECURITY_MACSEC_NUM_AN]; > /** Channel is active */ > uint8_t active : 1; > + /** Extended packet number is enabled for SAs */ > + uint8_t is_xpn : 1; > /** Reserved bitfields for future */ > - uint8_t reserved : 7; > + uint8 Is this an ABI change? If so needs to wait for 23.11 release