From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0937942BFC; Thu, 1 Jun 2023 05:15:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4766406B3; Thu, 1 Jun 2023 05:15:18 +0200 (CEST) Received: from mail-io1-f74.google.com (mail-io1-f74.google.com [209.85.166.74]) by mails.dpdk.org (Postfix) with ESMTP id 3B193406A2 for ; Thu, 1 Jun 2023 05:15:17 +0200 (CEST) Received: by mail-io1-f74.google.com with SMTP id ca18e2360f4ac-7775a282e25so49811939f.0 for ; Wed, 31 May 2023 20:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685589316; x=1688181316; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=NgSjksT2tx7UUwfrXacnaM/kBvqaKvmA8Xyr66j25K4=; b=fDfu8Sw+0chj13VUe3ApJsnGlXoMFg//WbngKIeUjNsVkYBthqkfkBhG1Oqn5fKVXR kCIzK0x/BXe12E+RLdbGYPV88kvgefATjTxJMadN2p8HsyZc+AtuEKhbyBsC6dAVwFmL eG6dcFa3sABeteCNny/NhdW+08R3Tv+LQLtHK4geRA2leLTr06A4+6dZrSiEkJCPmDVP Jhseiyz7DYssCKSYGCT9LaywEPu7Ef4sPMkhKXy58ZwbaGb6+EXk2SfGIMPAtArzhy+v 1SZkX6r8WofhSb9G7rtVO996ECKnXlhE0nuyuWfQqPRQlDoam15/P94GEc+4b+y/E97Y rLPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685589316; x=1688181316; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NgSjksT2tx7UUwfrXacnaM/kBvqaKvmA8Xyr66j25K4=; b=jEFy/uuVURwE2diuy5EEZnMyXQdhZcC0HSCAwzlwplJTtAlVx5eRnV92OwW06NLuuw 0hbeFcQHUMNl4HvEqsmbeH5BuZBKXjEWrQFueQo2mCQAQzeHTDYdTkWR/5xCJ33mJx/G R2cApcz6G8BKT3qH9/iRY2gm0yIfq+KidrbwNzDwnwjOcXOmP0B4AAZPxZpYgzlQP52u httXl3lqBsgeRMq2lKaXOvm7CarddsXcFKIkOciha+gS8tlDUsVqJJf5RDVfyt7b0jka Q2H5rU/yB+yqgJSzDXzX6QZ+fCIawxauDMck0kbRle+Ilkm5MCbBHG5LK3mnuvSlK4eD UDFQ== X-Gm-Message-State: AC+VfDwBSIt+ZbbvA0DW1Pkg8zwwAm1ujDcVc23dJtR/gjG92oxsDTPq sCBOocIBk4a/j8vrdPoLzcYGQ/BnXXCA X-Google-Smtp-Source: ACHHUZ7zMJX8fAWo950JyK6Ri5kJMGXacu7RCADbseEkEzcKKr92a2NZnxtwovp+fBgQD+Xol13+jTPY7On0 X-Received: from rushilg.c.googlers.com ([fda3:e722:ac3:cc00:2b:ff92:c0a8:f27]) (user=rushilg job=sendgmr) by 2002:a05:6638:cdc:b0:40f:7de9:c379 with SMTP id e28-20020a0566380cdc00b0040f7de9c379mr3151344jak.5.1685589316622; Wed, 31 May 2023 20:15:16 -0700 (PDT) Date: Thu, 1 Jun 2023 03:15:13 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.rc2.161.g9c6817b8e7-goog Message-ID: <20230601031513.453016-1-rushilg@google.com> Subject: [PATCH] net/gve: fix bug in verify driver compatibility From: Rushil Gupta To: qi.z.zhang@intel.com, ferruh.yigit@amd.com Cc: junfeng.guo@intel.com, dev@dpdk.org, Rushil Gupta Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org gVNIC requires physical address to be passed in the adminq command. This was initially rightly pointed by ferruh.yigit@. Fixed by passing 'driver_info_mem->iova'. Signed-off-by: Rushil Gupta --- drivers/net/gve/gve_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c index 2c1e73d07a..1c5ce930a4 100644 --- a/drivers/net/gve/gve_ethdev.c +++ b/drivers/net/gve/gve_ethdev.c @@ -276,7 +276,8 @@ gve_verify_driver_compatibility(struct gve_priv *priv) (char *)driver_info->os_version_str2); err = gve_adminq_verify_driver_compatibility(priv, - sizeof(struct gve_driver_info), (dma_addr_t)driver_info); + sizeof(struct gve_driver_info), + (dma_addr_t)driver_info_mem->iova); /* It's ok if the device doesn't support this */ if (err == -EOPNOTSUPP) err = 0; -- 2.41.0.rc2.161.g9c6817b8e7-goog