From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E4EA42BFD; Thu, 1 Jun 2023 06:49:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11217406B3; Thu, 1 Jun 2023 06:49:55 +0200 (CEST) Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by mails.dpdk.org (Postfix) with ESMTP id AD6D1406A2 for ; Thu, 1 Jun 2023 06:49:53 +0200 (CEST) Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-568960f4596so6673397b3.1 for ; Wed, 31 May 2023 21:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685594993; x=1688186993; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=m09wF8wGHJvC77GwFUGy2yKEzz2CGNSm1Y2QRhx77xY=; b=seEFQks9d+d+jBtr6A1CAaNqZyglTcT0DQ+upv4NCd9l1TKvZv90yNYTT9RJgZzFrK 3Xy1gVKi/CqZ1gjp06+WshfukkYQC947L9RHn9/XBviVlfz+QEqyx85QLBI74nGjT/G9 zKSu6li7BmNSt+jdDdrpOuYfkVST/vxt1Z6XEB1y+NzS/WvPo6mwNFF3y0RUMOhCBIQI MuIAlysNapa/8X2KlES7MFVZm6Vt7lGDYImCpoQ1hcZ6MgVGI88fjafBNjBLy0OZXDLk av4JR9k9XkzewddSa2I0WzwV8nDwLR0ICYn61uOqJcGSDotLcUMJKBU5p40wifoia1ZY AVuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685594993; x=1688186993; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m09wF8wGHJvC77GwFUGy2yKEzz2CGNSm1Y2QRhx77xY=; b=lOff/+Yc+lTbb61Qh6bEJsfPg2VqcaquaytIG+gkIztvGsNp+zRZDyZwbsnOkzokrp VADEFsnrzNcHCEhN0j6Rh/x1tWoDcAYXI/7sHU9LuFzRhVn19qG0obbyc/t4b4j3P/GA PgRx1zIjw70oJuxoCg9Rv6EswdJTtx2qHzPYmBH5j5esqqMj/G+8aljKEyz4idho6ZHT RulpPIbR67aarBHUbd8aUUJkuY2NSpTCaMjuABPcJXdFs/Qj85x0CxVkPx2tdSv1jOLf lfM4gul+aCalpoB5ZSIs4sGgb7AgsywlN6t2ZtCfNVisxGlcoA4RMBI1NdGpEa43lw9x szJw== X-Gm-Message-State: AC+VfDyDy/lw4/qiMU5fOflQpNnftr/51AeYaAlv9ipQd2u9otIqG1Pt CJ21ZchJJBC792RDkd9GZ8Pikh2nE+e2 X-Google-Smtp-Source: ACHHUZ6W+h3os5ZeleHnnJjoOyF6egsCriqnm+vQ2/7cEyusB+5C/SyztcodrDSJum9gNCuw9MNhYc+finC3 X-Received: from rushilg.c.googlers.com ([fda3:e722:ac3:cc00:2b:ff92:c0a8:f27]) (user=rushilg job=sendgmr) by 2002:a81:4047:0:b0:55d:95b7:39d8 with SMTP id m7-20020a814047000000b0055d95b739d8mr4647024ywn.7.1685594993034; Wed, 31 May 2023 21:49:53 -0700 (PDT) Date: Thu, 1 Jun 2023 04:49:50 +0000 In-Reply-To: <20230601031513.453016-1-rushilg@google.com> Mime-Version: 1.0 References: <20230601031513.453016-1-rushilg@google.com> X-Mailer: git-send-email 2.41.0.rc2.161.g9c6817b8e7-goog Message-ID: <20230601044950.465926-1-rushilg@google.com> Subject: [PATCH] net/gve: fix bug in verify driver compatibility From: Rushil Gupta To: qi.z.zhang@intel.com, ferruh.yigit@amd.com Cc: junfeng.guo@intel.com, dev@dpdk.org, Rushil Gupta Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org gVNIC requires physical address to be passed in the adminq command. This was initially rightly pointed by ferruh.yigit@. Fixed by passing 'driver_info_mem->iova'. Signed-off-by: Rushil Gupta --- drivers/net/gve/gve_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c index 2c1e73d07a..aa75abe102 100644 --- a/drivers/net/gve/gve_ethdev.c +++ b/drivers/net/gve/gve_ethdev.c @@ -276,7 +276,8 @@ gve_verify_driver_compatibility(struct gve_priv *priv) (char *)driver_info->os_version_str2); err = gve_adminq_verify_driver_compatibility(priv, - sizeof(struct gve_driver_info), (dma_addr_t)driver_info); + sizeof(struct gve_driver_info), + (dma_addr_t)driver_info_mem->iova); /* It's ok if the device doesn't support this */ if (err == -EOPNOTSUPP) err = 0; -- 2.41.0.rc2.161.g9c6817b8e7-goog