From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EFFE42C12; Fri, 2 Jun 2023 23:19:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 840DD40ED8; Fri, 2 Jun 2023 23:19:57 +0200 (CEST) Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by mails.dpdk.org (Postfix) with ESMTP id 31005406B8 for ; Fri, 2 Jun 2023 23:19:56 +0200 (CEST) Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-3f81396e435so23612801cf.0 for ; Fri, 02 Jun 2023 14:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685740795; x=1688332795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=tMh0nT3ng8d+qJNCvmxW2vxnAtJWkQhWZrUzvDD71JM=; b=H4d7iDGPLo8vTBgDIzuZM/WxkmoL5xsQaAIlJoC01oxmOTY4xhiZ+k1tA3tiIdbRDB rarfpkbFsxWjwcQtwRIeKy8201KuvYDeRwNR6ouWG7oyo2HafXtDgL2kgv2Nqj5Ilvhz bptREc+FGD3nvXAWblgG7uZ9H1QzUi9AdggjAF5hpCXoIaHPy/a1rWWSwD4lI+irrQMV QRYDz419JE9IZGojGlYdlhpqQv5zsqmBxdVEZQe6Ii8M3LyVWCDQzzpz7FYC8HeqMiaK +68smcmTCpjNn4l1kogata74HALyROv0ZITUQnvQPHHa7AnN8GVKDhmXR5heRq6Vp4Z4 bjAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685740795; x=1688332795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tMh0nT3ng8d+qJNCvmxW2vxnAtJWkQhWZrUzvDD71JM=; b=iWfTPVUIh2zWYcZ7CQB8HS+C7VZQJ25MH+jqxB0xTVW7EuM8UySqT27j9E2KbpnWaK Ft3oKMYssv1ZR6bqC9SRWAIeIeNAUJdMByQ7R9ZyS3srYhJlS7ec8tTNDnAYByZZTSke xVxg1PHpVvA/GQsMaLwrKA8xq/Ii/RlgwpVcxtCQAMgIIOp2C5T3YLfvH5kGrU+vHCnp 4mY89y9HCS5C9w5TO3CqQPIysQiOtYEVC2GH0I71CbIXry3HJ3B7EVHDBDYqR7kYlTAJ UmgS1A1BbPyMPBrBeDXFTLG10p/TPZeM0XGCb7UPG8HhEzm2pzSy7uFSBUTHuFqkefSl 1n5g== X-Gm-Message-State: AC+VfDyqQI9Bf05PBWh3fjDHaLdgFpQGBWG2R3m2vYJdv8A/idHxvUZx MJ1KZOsOFnkEGMgXYWHU8M9aBg== X-Google-Smtp-Source: ACHHUZ4lm+J/ZB5B8LrVQZ71oO38t56EhoAzVxmXwMTH8kTIn+xoS7e/cLV1+trXsMdo1IuXq9mu0A== X-Received: by 2002:a05:622a:489:b0:3f5:456b:d565 with SMTP id p9-20020a05622a048900b003f5456bd565mr18107058qtx.24.1685740795429; Fri, 02 Jun 2023 14:19:55 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id j19-20020a63ec13000000b0052c3f0ae381sm1660590pgh.78.2023.06.02.14.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jun 2023 14:19:55 -0700 (PDT) Date: Fri, 2 Jun 2023 14:19:52 -0700 From: Stephen Hemminger To: Dongdong Liu Cc: , , , , , , , Jie Hai , Maryam Tahhan , Vipin Varghese , John McNamara Subject: Re: [PATCH 3/5] app/proc-info: fix never show RSS info Message-ID: <20230602141952.41ab2f58@hermes.local> In-Reply-To: <20230315110033.30143-4-liudongdong3@huawei.com> References: <20230315110033.30143-1-liudongdong3@huawei.com> <20230315110033.30143-4-liudongdong3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 15 Mar 2023 19:00:31 +0800 Dongdong Liu wrote: > + rss_key = rte_malloc(NULL, > + dev_info.hash_key_size * sizeof(uint8_t), 0); > + if (rss_key == NULL) > + return; Don't use rte_malloc() unless this is a structure that needs to be shared between primary/secondary. In this case it doesn't need to be shared; so just use calloc().