From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71C3542C12; Fri, 2 Jun 2023 23:46:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5515C40ED8; Fri, 2 Jun 2023 23:46:37 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id D722E406B8 for ; Fri, 2 Jun 2023 23:46:35 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 15CC920520BB; Fri, 2 Jun 2023 14:46:35 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 15CC920520BB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1685742395; bh=IskXBugjm5LJurgsEwjuPJSrpT5HlNTkElC05e+1RQM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I4DZX1yrDSxr5caRgmvEDSbnoLh3U3UtXrr/ARGv++WbZS6JRz1n0UpYUDkDe9vJZ QLNT/OPwjOaa0rw9B1uxLBV1s2I9QYU/hi9bXBorCv2eyX+g3z7ZpJRt3iUwGBt6TU SmJrsAPdfNEwLLfepFSv/uDMbbgTUnixQIQBe7yY= Date: Fri, 2 Jun 2023 14:46:35 -0700 From: Tyler Retzlaff To: Bruce Richardson Cc: Stephen Hemminger , dev@dpdk.org Subject: Re: [PATCH 0/2] cleanup use of rte_strlcpy Message-ID: <20230602214635.GB28889@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230531220533.29910-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 01, 2023 at 11:18:52AM +0100, Bruce Richardson wrote: > On Wed, May 31, 2023 at 03:05:31PM -0700, Stephen Hemminger wrote: > > In DPDK API's rte_strlcpy() is not intended to be used directly. > > It was introduced as a replacement for when operating system > > libraries were missing strlcpy(). Over time it appears several > > drivers and subsystems started using it directly, which is > > inefficient since the wrapper uses snprintf(). > > > > This series makes sure that the only usage of rte_strlcpy() > > is in rte_string_fns.h where it is needed. > > > > Perhaps checkpatch should warn about other uses? > > > > Stephen Hemminger (2): > > lib: replace rte_strlcpy() with strlcpy() > > drivers: don't use rte_strlcpy > > > Acked-by: Bruce Richardson Acked-by: Tyler Retzlaff