From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA66442C40; Tue, 6 Jun 2023 17:36:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16129410DD; Tue, 6 Jun 2023 17:36:18 +0200 (CEST) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 02C974067B for ; Tue, 6 Jun 2023 17:36:15 +0200 (CEST) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6563ccf5151so3675765b3a.0 for ; Tue, 06 Jun 2023 08:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686065775; x=1688657775; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hjOboi1NWKL1pUcBeFtvBrinrOB/A26LZ8ma+2ZVoc0=; b=FZEt/qnGox5EJuVE9sU4IAtHEHHc9zlGgUdAZBysh++Mt90NzKp9ERwx7EGASz7wii 7aLIZf9x5Cxr8+A8y0F/dnfYeOC9Q7CWaJi+bSdw2TeMjdmOkH/ChsY+hgjxRt89UShI XsxJrM8HwvR8FajA6QoAWjVp/ueEAGZQY5J3VU1OLySkoF376HwQX1najOhG1BN9hQn3 B612KKarKkUGlzG+GRISy08AGqA+KZcQtR4l8b1JLDE7dRH4xvH7KEWaG7DQsrd2c7yF IdteVo1xiDqKiA2Sn/6Nb2cKt+tcFiQ4f53XOrjyJDIqv4Qjaf1B7Rkqh3Bk/WQKPG7x dGkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686065775; x=1688657775; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hjOboi1NWKL1pUcBeFtvBrinrOB/A26LZ8ma+2ZVoc0=; b=IMPT5U4b5a0r58xcRin9wvk9ExCGlMnSwlVyvKf1BPHOg1H19Rivig07e1WXZrAPKH EkChVMIzG1EIpMmcjFFWHTQ3yUgjwKbBcCNc9ob+E+hcN8HikvdnmlQ/uYyYRDdfa9WC Xi0oLvPKeyZKTHb0xDXuwumegQvlqrdflfwD1r9zMtUSdk78bHie1PZ1B85T+I/t/f+S qSeAkLfP2iaXnRrwWVsG4C9fMoSZM4lP6croxuQ9SA7ycQRajDqWOP3OXuCIv0VHL/xV jMc4f6+nImcf61LpSmzYkhyxsf13zSi8oXRuE2adt5pRLmC5hbs6VXngWrOPaTu21HWi eVEg== X-Gm-Message-State: AC+VfDyRB1ybu235XnJpBoZyvmqPXQJqjuppnPqCWvXpMee2AWRhwYz9 udAEkBSBVZ0m8HV2C1AN7v8DdA== X-Google-Smtp-Source: ACHHUZ6rAa6utRCt6koKniZb6B2nK6TzHZLpispjBoM/zVHJZI3pJ2W5qy/+Qmi0ccGCixehCCYyHQ== X-Received: by 2002:a05:6a20:e688:b0:10c:29e5:941e with SMTP id mz8-20020a056a20e68800b0010c29e5941emr3189581pzb.59.1686065775044; Tue, 06 Jun 2023 08:36:15 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id v3-20020aa78083000000b0062bc045bf4fsm7238588pff.19.2023.06.06.08.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 08:36:14 -0700 (PDT) Date: Tue, 6 Jun 2023 08:36:12 -0700 From: Stephen Hemminger To: Kaijun Zeng Cc: dev@dpdk.org, Ferruh Yigit , stable@dpdk.org, Jochen Behrens , Bruce Richardson Subject: Re: [PATCH v2] net/vmxnet3: fix return code in initializing Message-ID: <20230606083612.6ee181d4@hermes.local> In-Reply-To: <20230602164438.45939-1-corezeng@gmail.com> References: <20230528143734.145326-1-user@sklga> <20230602164438.45939-1-corezeng@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 2 Jun 2023 12:44:38 -0400 Kaijun Zeng wrote: > + PMD_INIT_LOG(ERR, > + "ERROR: Zero descriptor requirement in Rx queue: %d," > + "buffers ring: %d\n", > + i, j); Please don't split messages across source lines, it makes harder for developers to use tools to scan source for message. Often, when message is long, it means that there is redundant information or poor wording. For example, in your message "ERROR:" is redundant.