From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC60442C40; Tue, 6 Jun 2023 18:35:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C602D4067B; Tue, 6 Jun 2023 18:35:46 +0200 (CEST) Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) by mails.dpdk.org (Postfix) with ESMTP id 5167540223 for ; Tue, 6 Jun 2023 18:35:45 +0200 (CEST) Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-5559cd68b67so4297238eaf.3 for ; Tue, 06 Jun 2023 09:35:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686069344; x=1688661344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=xA0FWaZPcWDje7Wjkob4D9nUnxeqD71goDPRmDPpo/4=; b=hwcyb2njJDaW1eGfgU9mBcZEKkorT96csqirnBM0yIhvxdW4ep5zKomQ2OVELeZgLJ GNQGcxMi5vbJtzK7MxvVj4ekNPCBYzlFm+C9zpyXyPw4w26gfNWIUox9RKAUzpyiE3QQ jL6QDcizJNyDzvAybzNZbMw69dUKAaS14OMFeyXV7i6ER7GvIQVttox+M+nvxBkHNOSB 3dRwso6MNevcifVkhnyrqHBaJhn9+ANh7lUlMYkP4o4G3pOHXD9fxLb+us+2zf2oQsr2 OYLJamkD7Smm3PStUgMcMd3lzi9rEr8fqjfJr4F403nqMJecGQ1uQST9Buow2tlR2zPM tIuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686069344; x=1688661344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xA0FWaZPcWDje7Wjkob4D9nUnxeqD71goDPRmDPpo/4=; b=CZjHEq79L84Pwvn2zFk7YlGd9wptMc675aW1imVk/3FLPt6TU7sT5+Fl7LnfWuygUc zM5ysF94+nUdN8y4tDTirQ93b9ZhZN1OM4TrFYLEI+WtGKNOe6aTmsI7PdvDIFIBy6cY QfQ6qgaWTRHt5qfVL4HsniUUkv+nMRe/vq2r8Wh3P7/VHDfYsY1WBGthAVjd5ObyxOUK +Z0ujXjbAbVlNe2l1MFvqtBlWQNRaF/7efPavR24d5rT5uJ/eDNKjSVVaHAj3OUJ23vo lAW/GYv+SHj+Ali08la6sqvsx8CDU9CO271uZAUIEgIt1IobB9O62o5Ocr9m1WQ7IezG Q5zQ== X-Gm-Message-State: AC+VfDzktt9PBDM7BE6lxmSBDcn5GMef2wN0kYR22FiHSuFlc+yvaldk uEbvaC2Xo67z0CtOt7u8ROntVw== X-Google-Smtp-Source: ACHHUZ6JKZOkpdTbVWuxOp+zBC+WL45KH+gX/UgHkkw+8TyDbDo2MzmR3bWu2l8h9d/dBcxTBzqYYw== X-Received: by 2002:a05:6358:c607:b0:129:cc30:cb22 with SMTP id fd7-20020a056358c60700b00129cc30cb22mr163288rwb.32.1686069344486; Tue, 06 Jun 2023 09:35:44 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id s1-20020a17090a2f0100b0023d386e4806sm8339355pjd.57.2023.06.06.09.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 09:35:44 -0700 (PDT) Date: Tue, 6 Jun 2023 09:35:42 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Dongdong Liu , dev@dpdk.org Subject: Re: [PATCH] doc: deprecation notice to add RSS hash algorithm field Message-ID: <20230606093542.351884fe@hermes.local> In-Reply-To: <6e9dd06f-6f90-b80f-7f26-3b8c58ea2036@amd.com> References: <20230606121126.9983-1-liudongdong3@huawei.com> <20230606083912.3e0bb5df@hermes.local> <6e9dd06f-6f90-b80f-7f26-3b8c58ea2036@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 6 Jun 2023 16:50:53 +0100 Ferruh Yigit wrote: > On 6/6/2023 4:39 PM, Stephen Hemminger wrote: > > On Tue, 6 Jun 2023 20:11:26 +0800 > > Dongdong Liu wrote: > > > >> Deprecation notice to add "func" field to ``rte_eth_rss_conf`` > >> structure for RSS hash algorithm. > >> > >> Signed-off-by: Dongdong Liu > >> --- > > > > New fields do not require deprecation notice. > > Since this seems to be a repeated issue, perhaps someone should > > add this to the documentation. > > > > > Hi Stephen, > > This is follow up to an existing patchset: > https://patches.dpdk.org/project/dpdk/list/?series=27400&state=* > > Although field is addition to the "struct rte_eth_rss_conf" struct, it > is embedded into "struct rte_eth_conf" which is parameter to an API, so > change cause size increase in outer struct and causes ABI breakage, > requiring deprecation notice. It will change ABI so will have to wait for 23.11. But the purpose of deprecation notice is more about telling users that API will change. The automated tools may give false complaint. Ok to add to deprecation, but really not necessary.