From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8A9842C6F; Fri, 9 Jun 2023 16:38:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99AE842D8F; Fri, 9 Jun 2023 16:38:46 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 79B2740EDB for ; Fri, 9 Jun 2023 16:38:45 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-652dd220d67so1877167b3a.3 for ; Fri, 09 Jun 2023 07:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686321524; x=1688913524; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=yjEvY83MrUrrCmlXoWOq4ozvCuyanVklsRbLZw7gMD8=; b=cwrwqtOEEMKijL6pkhNtPLMVCO/LL1d7ejOWqGXTrGaXdCVlFSySBXPlRh02CEqD9G OEXO6i+tkSCws7EcfLZhsJpp9tpvbR3Q2esTqVRC+XlL1gFjJ3qka+8GSBqMNVtymCyr Jm/8Lme6otPenVm+xkvyhZNkiheKCnO3+vUj1SleKRH9R+DAQRweUPc0CgrUqfNx2on6 aDOw0OPPmbnk9f2X/el5GRQrgsIos3H8f3u5W8cvqRZW4KbNu3e+6MsftyXO4QkNp8Ov UrSr9YP/nVPQUlpPvj8JE/2mtQnm7or2gHYzvRO/tm6TPlGXMIMm+73nsH1sWdNDThFM OPIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686321524; x=1688913524; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yjEvY83MrUrrCmlXoWOq4ozvCuyanVklsRbLZw7gMD8=; b=dMN3kGPTJvAxuCraNy6izBFL29byONDFfrM9NA4PQGgBiIoSkMyILRebkVZYc1mUd0 cd5Xl7d+1IWucbooAeAbrec9lvCjecDvzT0Vw87EcFWHqpXrtL8ONoPDmS7YcrRfHyCJ lhu26LpyKa/9Mmt1qGn8vahFY4rkdD1UYlNVm7KOrNCHMLCDm7kKosfApI6VsSGkirL1 nxuGTwmlI5FnIcHnkZgHTyzJ60QlruKMNdRD1uvJXQt+zH/5lGmovDQYm0FsRitHYdeN dAL6x/We/e9Qjx9uAP/tlSKHMKiJBXBv5vVGpWQUqsW1XvE4HhNmBBQYt3qjWN2lPx0I 6e1w== X-Gm-Message-State: AC+VfDzrY48X2E1SNjA5NMcPr/ksGMyqwnU7/McPL9qyn93yYgIpFiZc kX76ep9MBaVTwGEe3jRL0ZMY9w== X-Google-Smtp-Source: ACHHUZ7BoGvj+/uJvE4J7K0UYp86Ve91nuqxgRxM+4oH5GuQw87yVgvWcZnW7Y9tQrcxlAVKX2X25g== X-Received: by 2002:a05:6a00:2382:b0:63b:8eeb:77b8 with SMTP id f2-20020a056a00238200b0063b8eeb77b8mr1908447pfc.13.1686321524523; Fri, 09 Jun 2023 07:38:44 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id s6-20020aa78286000000b0064ceb16a1a8sm2654017pfm.33.2023.06.09.07.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 07:38:44 -0700 (PDT) Date: Fri, 9 Jun 2023 07:38:42 -0700 From: Stephen Hemminger To: Zhichao Zeng Cc: dev@dpdk.org, qi.z.zhang@intel.com, daxuex.gao@intel.com, Bruce Richardson , Konstantin Ananyev , Jingjing Wu , Beilei Xing , Wenjun Wu Subject: Re: [PATCH] net/iavf: fix old GCC compilation warnings Message-ID: <20230609073842.597ae326@hermes.local> In-Reply-To: <20230609054156.605581-1-zhichaox.zeng@intel.com> References: <20230609054156.605581-1-zhichaox.zeng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 9 Jun 2023 13:41:56 +0800 Zhichao Zeng wrote: > The code uses the Wimplicit-fallthrough compile option to ignore > falls through warnings in switch case, but this option was introduced > by GCC 7 and old GCC do not recognize the option. > > Add judgment to avoid warnings about unrecognized options in old GCC. > > Fixes: 95a1b0b23140 ("net/iavf: support Rx timestamp offload on SSE") > Fixes: 4f58266da4d3 ("net/iavf: support Rx timestamp offload on AVX2") > Fixes: d65eadb9e178 ("net/iavf: support Rx timestamp offload on AVX512") > Signed-off-by: Zhichao Zeng > --- RHEL 7 becomes end of life this month. That makes the oldest version of Gcc that DPDK is required to support is gcc 8.X in RHEL 8.