From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, kai.ji@intel.com, g.singh@nxp.com,
hemant.agrawal@nxp.com, pablo.de.lara.guarch@intel.com,
fanzhang.oss@gmail.com
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [PATCH 5/6] crypto/ipsec_mb: remove security lib presence checks
Date: Fri, 9 Jun 2023 15:54:49 +0200 [thread overview]
Message-ID: <20230609135450.476983-6-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20230609135450.476983-1-maxime.coquelin@redhat.com>
Since security library is a required dependency for
building ipsec_mb crypto PMD, remove useless check before
security lib headers inclusion.
The patch also takes the opportunity to remove unused
related defines.
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
drivers/crypto/ipsec_mb/ipsec_mb_private.h | 3 ---
drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 4 ----
2 files changed, 7 deletions(-)
diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.h b/drivers/crypto/ipsec_mb/ipsec_mb_private.h
index ab27214f2c..52722f94a0 100644
--- a/drivers/crypto/ipsec_mb/ipsec_mb_private.h
+++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.h
@@ -13,11 +13,8 @@
#include <cryptodev_pmd.h>
#include <bus_vdev_driver.h>
-#if defined(RTE_LIB_SECURITY)
-#define IPSEC_MB_DOCSIS_SEC_ENABLED 1
#include <rte_security.h>
#include <rte_security_driver.h>
-#endif
/* Maximum length for digest */
#define DIGEST_LENGTH_MAX 64
diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h
index 8a7c74f621..fee02306c1 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h
@@ -5,12 +5,10 @@
#ifndef _PMD_AESNI_MB_PRIV_H_
#define _PMD_AESNI_MB_PRIV_H_
-#if defined(RTE_LIB_SECURITY)
#define AESNI_MB_DOCSIS_SEC_ENABLED 1
#include <rte_security.h>
#include <rte_security_driver.h>
#include <rte_ether.h>
-#endif
#include "ipsec_mb_private.h"
@@ -960,7 +958,6 @@ typedef void (*hash_one_block_t)(const void *data, void *digest);
typedef void (*aes_keyexp_t)(const void *key, void *enc_exp_keys,
void *dec_exp_keys);
-#ifdef AESNI_MB_DOCSIS_SEC_ENABLED
static const struct rte_cryptodev_capabilities
aesni_mb_pmd_security_crypto_cap[] = {
{ /* AES DOCSIS BPI */
@@ -1008,6 +1005,5 @@ static const struct rte_security_capability aesni_mb_pmd_security_cap[] = {
.action = RTE_SECURITY_ACTION_TYPE_NONE
}
};
-#endif
#endif /* _PMD_AESNI_MB_PRIV_H_ */
--
2.40.1
next prev parent reply other threads:[~2023-06-09 13:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 13:54 [PATCH 0/6] Trivial crypto PMDs cleanup Maxime Coquelin
2023-06-09 13:54 ` [PATCH 1/6] crypto/qat: fix sym device prototype Maxime Coquelin
2023-06-09 14:03 ` Zhang, Fan
2023-06-09 15:40 ` Tyler Retzlaff
2023-06-09 13:54 ` [PATCH 2/6] crypto/qat: remove security lib presence checks Maxime Coquelin
2023-06-09 13:54 ` [PATCH 3/6] crypto/dpaa2_sec: " Maxime Coquelin
2023-06-09 15:04 ` Hemant Agrawal
2023-06-09 13:54 ` [PATCH 4/6] crypto/dpaa_sec: " Maxime Coquelin
2023-06-09 15:05 ` Hemant Agrawal
2023-06-09 13:54 ` Maxime Coquelin [this message]
2023-06-09 13:54 ` [PATCH 6/6] crypto/qat: remove useless log level checks Maxime Coquelin
2023-06-09 14:02 ` Zhang, Fan
2023-06-14 18:17 ` [EXT] [PATCH 0/6] Trivial crypto PMDs cleanup Akhil Goyal
2023-06-20 6:49 ` Akhil Goyal
2023-06-20 7:54 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609135450.476983-6-maxime.coquelin@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=g.singh@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=kai.ji@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).