From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 048EF42C74; Sun, 11 Jun 2023 04:45:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86405400D5; Sun, 11 Jun 2023 04:45:31 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 152004003C for ; Sun, 11 Jun 2023 04:45:29 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-652a6cf1918so2588001b3a.1 for ; Sat, 10 Jun 2023 19:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686451529; x=1689043529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=rTcDwC71TPtiF6VqMP0vgZSa1f8Qn0qDqnVPot9ViGQ=; b=1kMBOBNGjNNr9MX3Qrx2gEVJL9HiMPsdhMPQ4nfGt/0njwbb5CQbQ7bv2sQHSNaRY7 T4OFZpCDjwR7WfNmUfGM0jRW9impmA/WxKEufOLXTESoCVN8spMnILV6PMuaLDDs4c73 VOg/PR1FhyJ/H1/THSg8N6zhLNzFajoS8ASTUd5naXOmdc9r2v1sa9dv8ytS1vU/Uayy 0zjQXVCjm7I01acWobuFwzUeGbTMN+34ufj3xwv8OCzU4yAMCrB805cfVqDrrkr6ycln woRdlxQB30fJAE8qfAdWNcB7a51KYBaVVYPLlCgFG9wjUxqtoK5z1i5qBQA0sBJVTbJE 8W9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686451529; x=1689043529; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rTcDwC71TPtiF6VqMP0vgZSa1f8Qn0qDqnVPot9ViGQ=; b=N7ooNCxwh3ejYs/+Oj2yBx9y/JeXJeVhMDpnaQlsN3wD7QfgNyLPxX99lpJTd6NimQ k6OyriGpAkXOLzGGW2l0IPF5VARL+hRWH73JTURNCa5q9/voCzmH2JYkSyiOsdAgEyg2 lX9Hb2upxJKYJYWoJthDdFh/QoTn+sLm8oMzGE9GO+faS1lwn8kquOWu1j3KtqJ15DOC sFHREBq0NYboMJzMiHVHNvSCOm6qT0pbbHzCPyg9y+S/4rf0dOda0/F4lrUrldcI2D3H hrjiTjoEbwtvqxEcZh0pJ8RPL6k7Obugh13jum9J4WhyOHkFgItdu1ZuZWf7irQxnYJ5 Z9+g== X-Gm-Message-State: AC+VfDxN2LRJ+7UtznOp+O4wHAkJxDqYfWmif8p7SKn5z/hK2arvMDP/ GBv8vi2scgSI5ampLaZ4EhdQWA== X-Google-Smtp-Source: ACHHUZ5HZRVDfPODRB9Ul1kHWHdbGQJtHD7lZmya+nVQ4k31bz2++jlVa6YKZiTr614czealdY0M3g== X-Received: by 2002:a05:6a00:1903:b0:662:6bf8:3509 with SMTP id y3-20020a056a00190300b006626bf83509mr5889852pfi.6.1686451528983; Sat, 10 Jun 2023 19:45:28 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id 3-20020aa79103000000b00625037cf695sm4704626pfh.86.2023.06.10.19.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jun 2023 19:45:28 -0700 (PDT) Date: Sat, 10 Jun 2023 19:45:26 -0700 From: Stephen Hemminger To: "Dumitrescu, Cristian" Cc: "Yigit, Ferruh" , "alanrobertsonatt@gmail.com" , "dev@dpdk.org" , Alan Robertson , Alan Robertson , Thomas Monjalon , "Singh, Jasvinder" Subject: Re: [dpdk-dev] [PATCH] Improve the shaper accuracy for large packets Message-ID: <20230610194526.1ab7ee81@hermes.local> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E8727B1@IRSMSX108.ger.corp.intel.com> References: <1518172716-7649-1-git-send-email-alanrobertsonatt@gmail.com> <620f62a4-279b-cdcb-5969-d2afd39cd87f@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E8727B1@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 8 Apr 2019 13:36:14 +0000 "Dumitrescu, Cristian" wrote: > > -----Original Message----- > > From: Yigit, Ferruh > > Sent: Friday, April 5, 2019 4:54 PM > > To: Dumitrescu, Cristian > > Cc: alanrobertsonatt@gmail.com; dev@dpdk.org; Alan Robertson > > ; Alan Robertson ; Thomas > > Monjalon > > Subject: Re: [dpdk-dev] [PATCH] Improve the shaper accuracy for large > > packets > > > > On 2/9/2018 10:38 AM, alanrobertsonatt@gmail.com wrote: > > > From: Alan Robertson > > > > > > There were 2 issues, the first was time could be lost whilst updating > > > the traffic-class period, the second was a frame could be delayed if > > > not enough tokens were available for the full frame. By allowing the > > > shaper to borrow credit from the next period the throughput is improved. > > > > > > Signed-off-by: Alan Robertson > > > > > > Hi Cristian, > > > > Another 'librte_sched' patch waiting for a review for almost a year now, do > > you > > know status of this patch? > > > > Thanks, > > ferruh > > As previously announced, we are planning to do some improvements on this part of the code [1] and we are planning improve this behavior in a way that is less intrusive and has slightly better performance (due to no branches). > > Regards, > Cristian > > [1] https://mails.dpdk.org/archives/dev/2018-November/120035.html > This patch is quite old. It looks the original issue was that rte_sched_port_dequeue is racy if port is shared by multiple lcore's. The only update to port->time happens in rte_sched_port_time_resync() frin rte_sched_port_dequeue(). The warnings about thread safety in qos_framework.rst could be improved, but that is something for another patch in future.