From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFCFB42C91; Mon, 12 Jun 2023 04:49:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42AC042D69; Mon, 12 Jun 2023 04:49:20 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 57FDD42D62 for ; Mon, 12 Jun 2023 04:49:19 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-662f0feafb2so2737018b3a.1 for ; Sun, 11 Jun 2023 19:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686538158; x=1689130158; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=RAeGBpQt/cVjZbSS6kgaZm8c9H6nZcdwF3ByfACoS/Y=; b=OenF7KOvDFfcssK8/KCd6GIGyDgmLn4JAZsJyXhN9IhKoirJSEJs289F9P9phHsHtq heo+l8i/uTRmUp24Fhn3DYlsCO5bBNIrXbUYLWWm7JXOz4cagXwure7qvuJNho22CcAO RU2qD/t6l2KqwBzldPlOf4YSrqwS9+upAGx0PTZBB7Uh5R0fkaG3/eY24bHWGTJrTXJo rCPZ7IUb7E/QDuPpBohdZR+cxz7+CAXeMndPEl50NIoV4sh0VSUVKVUxTbuLOlZG4G1i 0D0DzONxxoXlvHM4Duiub3VwC0D2moUVog7vpZoT0EEUok/IVLN8O0IjIEcK6PVNRj5j r2Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686538158; x=1689130158; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RAeGBpQt/cVjZbSS6kgaZm8c9H6nZcdwF3ByfACoS/Y=; b=DpaZ5hDFmzxqx5urc5MUDKEAcjHnewyiVI3B7zHsmuyt9+VttJ84vCNspIuqmkVn2z R7Db/+Ue/GaiKfmYS5jD3s1JTY6l+0YSlOh+7x4bA3uir/9Wx7ZJ4aRF6l+8RP25uaP8 G8krtfk83IIWkq4/gj9EQoQNm7yAe7NbpAOM7Zu2a1HLxyud0gQe2v7QL7AtYxoSOobj umOq/gfJR+wHmCMA2xwLKh+rzLwB8DZ6/pZbCZvE4Gd+SyqIDPIgsUwpcEhBQr0p4JwR 5tVqkjFpl8i5/SZHVEjtK0kt890slA9dV+8OgA07XKUH4WS9MHeUPJ8sGaGg/v6Ec5ym Tywg== X-Gm-Message-State: AC+VfDza304pS7KIKNQPzZ+YtDNw98CxUpDvLWUW/WoOTFcJzynt/Mbq 0WOXgTgq+IBtf32tVTG85BCE4A== X-Google-Smtp-Source: ACHHUZ7meyPkMDp33QHB4K8BkhqAqtJwEzkite116ORiadZjgVEDT679egQ8FNT4LrLwtKoVvIOclQ== X-Received: by 2002:a05:6a20:2445:b0:113:d42c:a909 with SMTP id t5-20020a056a20244500b00113d42ca909mr9495777pzc.6.1686538158260; Sun, 11 Jun 2023 19:49:18 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id z10-20020aa791ca000000b006610b89d53bsm5844165pfa.73.2023.06.11.19.49.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jun 2023 19:49:17 -0700 (PDT) Date: Sun, 11 Jun 2023 19:49:09 -0700 From: Stephen Hemminger To: David Marchand Cc: nhorman@tuxdriver.com, dev@dpdk.org, thomas@monjalon.net, arybchenko@solarflare.com, stable@dpdk.org, Ray Kinsella , John McNamara , Marko Kovacevic , Qiming Yang , Wenzhuo Lu , Declan Doherty , Adrien Mazarguil , Ferruh Yigit , Cristian Dumitrescu Subject: Re: [dpdk-dev] [RFC PATCH] mark experimental variables Message-ID: <20230611194909.738886c9@hermes.local> In-Reply-To: <20191125161314.18804-1-david.marchand@redhat.com> References: <20191125161314.18804-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 25 Nov 2019 17:13:14 +0100 David Marchand wrote: > So far, we did not pay attention to direct access to variables but they > are part of the API/ABI too and should be clearly identified. > > Introduce a __rte_experimental_var tag and mark existing variables. > > Fixes: a4bcd61de82d ("buildtools: add script to check experimental API exports") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > Quick patch to try to catch experimental variables. > Not sure if we could use a single section, so please advise if there is > better to do about this. > > --- > buildtools/check-experimental-syms.sh | 17 +++++++++++++++-- > devtools/checkpatches.sh | 14 +++++++++----- > doc/guides/contributing/abi_policy.rst | 7 ++++--- > drivers/net/ice/rte_pmd_ice.h | 3 +++ > lib/librte_cryptodev/rte_crypto_asym.h | 3 +++ > lib/librte_eal/common/include/rte_compat.h | 5 +++++ > lib/librte_ethdev/rte_flow.h | 17 +++++++++++++++++ > lib/librte_port/rte_port_eventdev.h | 5 +++++ > 8 files changed, 61 insertions(+), 10 deletions(-) This is a good idea, but the patch has gone stale in 4 years. Symbols have changed, directories have changed. If someone wants to continue this, please rebase and recheck. Marking the original patch with Changes Requested.