From: Stephen Hemminger <stephen@networkplumber.org>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: john.mcnamara@intel.com, ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
Date: Mon, 12 Jun 2023 08:59:11 -0700 [thread overview]
Message-ID: <20230612085911.438860bb@hermes.local> (raw)
In-Reply-To: <20190311183939.21166-1-ktraynor@redhat.com>
On Mon, 11 Mar 2019 18:39:39 +0000
Kevin Traynor <ktraynor@redhat.com> wrote:
> Make clear that spaces are only for alignments less than tab size.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> doc/guides/contributing/coding_style.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
> index d96698a73..dd7ddc21e 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -348,5 +348,5 @@ General
> .. note::
>
> - Global whitespace rule in DPDK, use tabs for indentation, spaces for alignment.
> + Global whitespace rule in DPDK, use tabs for indentation, spaces for smaller alignments.
>
> * Do not put any spaces before a tab for indentation.
Dropping this patch, the wording makes sense but the responses bordered on bike shedding
about white space.
IMHO we should get some automated tools involved (like clang format) to handle whitespace
inconsistency.
prev parent reply other threads:[~2023-06-12 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 18:39 Kevin Traynor
2019-03-11 23:08 ` Rami Rosen
2019-03-25 11:36 ` Kovacevic, Marko
2019-03-25 11:36 ` Kovacevic, Marko
2020-05-24 22:47 ` Thomas Monjalon
2020-05-25 9:54 ` Mcnamara, John
2023-06-12 15:59 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612085911.438860bb@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=ktraynor@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).