* [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
@ 2019-03-11 18:39 Kevin Traynor
2019-03-11 23:08 ` Rami Rosen
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Kevin Traynor @ 2019-03-11 18:39 UTC (permalink / raw)
To: john.mcnamara, ferruh.yigit, dev; +Cc: Kevin Traynor
Make clear that spaces are only for alignments less than tab size.
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
doc/guides/contributing/coding_style.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
index d96698a73..dd7ddc21e 100644
--- a/doc/guides/contributing/coding_style.rst
+++ b/doc/guides/contributing/coding_style.rst
@@ -348,5 +348,5 @@ General
.. note::
- Global whitespace rule in DPDK, use tabs for indentation, spaces for alignment.
+ Global whitespace rule in DPDK, use tabs for indentation, spaces for smaller alignments.
* Do not put any spaces before a tab for indentation.
--
2.20.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
2019-03-11 18:39 [dpdk-dev] [PATCH] doc: clarify spaces for alignment note Kevin Traynor
@ 2019-03-11 23:08 ` Rami Rosen
2019-03-25 11:36 ` Kovacevic, Marko
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Rami Rosen @ 2019-03-11 23:08 UTC (permalink / raw)
To: Kevin Traynor; +Cc: John McNamara, Ferruh Yigit, dev
> Make clear that spaces are only for alignments less than tab size.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>
Acked-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
2019-03-11 18:39 [dpdk-dev] [PATCH] doc: clarify spaces for alignment note Kevin Traynor
2019-03-11 23:08 ` Rami Rosen
@ 2019-03-25 11:36 ` Kovacevic, Marko
2019-03-25 11:36 ` Kovacevic, Marko
2020-05-24 22:47 ` Thomas Monjalon
2023-06-12 15:59 ` Stephen Hemminger
3 siblings, 1 reply; 7+ messages in thread
From: Kovacevic, Marko @ 2019-03-25 11:36 UTC (permalink / raw)
To: Kevin Traynor, Mcnamara, John, Yigit, Ferruh, dev
> Subject: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
>
> Make clear that spaces are only for alignments less than tab size.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> doc/guides/contributing/coding_style.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/contributing/coding_style.rst
> b/doc/guides/contributing/coding_style.rst
> index d96698a73..dd7ddc21e 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -348,5 +348,5 @@ General
> .. note::
>
> - Global whitespace rule in DPDK, use tabs for indentation, spaces for
> alignment.
> + Global whitespace rule in DPDK, use tabs for indentation, spaces for
> smaller alignments.
>
> * Do not put any spaces before a tab for indentation.
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
2019-03-25 11:36 ` Kovacevic, Marko
@ 2019-03-25 11:36 ` Kovacevic, Marko
0 siblings, 0 replies; 7+ messages in thread
From: Kovacevic, Marko @ 2019-03-25 11:36 UTC (permalink / raw)
To: Kevin Traynor, Mcnamara, John, Yigit, Ferruh, dev
> Subject: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
>
> Make clear that spaces are only for alignments less than tab size.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> doc/guides/contributing/coding_style.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/contributing/coding_style.rst
> b/doc/guides/contributing/coding_style.rst
> index d96698a73..dd7ddc21e 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -348,5 +348,5 @@ General
> .. note::
>
> - Global whitespace rule in DPDK, use tabs for indentation, spaces for
> alignment.
> + Global whitespace rule in DPDK, use tabs for indentation, spaces for
> smaller alignments.
>
> * Do not put any spaces before a tab for indentation.
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
2019-03-11 18:39 [dpdk-dev] [PATCH] doc: clarify spaces for alignment note Kevin Traynor
2019-03-11 23:08 ` Rami Rosen
2019-03-25 11:36 ` Kovacevic, Marko
@ 2020-05-24 22:47 ` Thomas Monjalon
2020-05-25 9:54 ` Mcnamara, John
2023-06-12 15:59 ` Stephen Hemminger
3 siblings, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2020-05-24 22:47 UTC (permalink / raw)
To: Kevin Traynor; +Cc: john.mcnamara, ferruh.yigit, dev
11/03/2019 19:39, Kevin Traynor:
> Make clear that spaces are only for alignments less than tab size.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> - Global whitespace rule in DPDK, use tabs for indentation, spaces for alignment.
> + Global whitespace rule in DPDK, use tabs for indentation, spaces for smaller alignments.
tab Vs spaces :D
I am not sure what is the most followed convention in DPDK.
I thought most of alignments were done with spaces only.
I mean spaces before an end-of-line comment:
struct foo {
int an_interesting_field; /* mandatory */
char poor_field; /* optional thing */
}
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
2020-05-24 22:47 ` Thomas Monjalon
@ 2020-05-25 9:54 ` Mcnamara, John
0 siblings, 0 replies; 7+ messages in thread
From: Mcnamara, John @ 2020-05-25 9:54 UTC (permalink / raw)
To: Thomas Monjalon, Kevin Traynor; +Cc: Yigit, Ferruh, dev
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Sunday, May 24, 2020 11:47 PM
> To: Kevin Traynor <ktraynor@redhat.com>
> Cc: Mcnamara, John <john.mcnamara@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
>
> 11/03/2019 19:39, Kevin Traynor:
> > Make clear that spaces are only for alignments less than tab size.
> >
> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> > ---
> > --- a/doc/guides/contributing/coding_style.rst
> > +++ b/doc/guides/contributing/coding_style.rst
> > - Global whitespace rule in DPDK, use tabs for indentation, spaces for
> alignment.
> > + Global whitespace rule in DPDK, use tabs for indentation, spaces for
> smaller alignments.
>
> tab Vs spaces 😃
The forever-war!
>
> I am not sure what is the most followed convention in DPDK.
> I thought most of alignments were done with spaces only.
That was my understanding too: tabs for indentation, spaces for alignment.
John
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
2019-03-11 18:39 [dpdk-dev] [PATCH] doc: clarify spaces for alignment note Kevin Traynor
` (2 preceding siblings ...)
2020-05-24 22:47 ` Thomas Monjalon
@ 2023-06-12 15:59 ` Stephen Hemminger
3 siblings, 0 replies; 7+ messages in thread
From: Stephen Hemminger @ 2023-06-12 15:59 UTC (permalink / raw)
To: Kevin Traynor; +Cc: john.mcnamara, ferruh.yigit, dev
On Mon, 11 Mar 2019 18:39:39 +0000
Kevin Traynor <ktraynor@redhat.com> wrote:
> Make clear that spaces are only for alignments less than tab size.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> doc/guides/contributing/coding_style.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
> index d96698a73..dd7ddc21e 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -348,5 +348,5 @@ General
> .. note::
>
> - Global whitespace rule in DPDK, use tabs for indentation, spaces for alignment.
> + Global whitespace rule in DPDK, use tabs for indentation, spaces for smaller alignments.
>
> * Do not put any spaces before a tab for indentation.
Dropping this patch, the wording makes sense but the responses bordered on bike shedding
about white space.
IMHO we should get some automated tools involved (like clang format) to handle whitespace
inconsistency.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-06-12 15:59 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 18:39 [dpdk-dev] [PATCH] doc: clarify spaces for alignment note Kevin Traynor
2019-03-11 23:08 ` Rami Rosen
2019-03-25 11:36 ` Kovacevic, Marko
2019-03-25 11:36 ` Kovacevic, Marko
2020-05-24 22:47 ` Thomas Monjalon
2020-05-25 9:54 ` Mcnamara, John
2023-06-12 15:59 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).