From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D91CE42C50; Mon, 12 Jun 2023 18:38:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B56D1410DD; Mon, 12 Jun 2023 18:38:21 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 212F740698 for ; Mon, 12 Jun 2023 18:38:20 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-652dd220d67so4686708b3a.3 for ; Mon, 12 Jun 2023 09:38:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686587899; x=1689179899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Of+wkhVri2wq6nlYGvKBkqxp/7dLsSitDHi+cUALhdo=; b=l5cL4Trag8sNWhp+62oRSplKREcAcRJgJ0x5/l6nO2syE/JPXe6XhyuSCHZOFzDKaZ 0kNbTKn7SlWu0NjzFlhsceU1RUzGIohhnrbC/wkSwBpVBYYnL2sGkK52sdVBfIDJqUl2 N9s8qiqTKVej1R0FYv1CwQqGHRijq+kGlF92bvVlwZAza9Y+HdvjkjKMDeVb79z4fJ9c GNbwCyGBaMqIZ7pAq1tdcTxDl8v8NKAzXVfioVVS9likXlvCefIMPrSSEJIchWIhAj8e wXDdd8C0b2VSPtxIkMDhicAgxnReVSdlIQrv6hcm9CPhlSWoTFgjmOrZx2rVZzkweINq Nb3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686587899; x=1689179899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Of+wkhVri2wq6nlYGvKBkqxp/7dLsSitDHi+cUALhdo=; b=O088AjSDs7ccXRd1KkCGViaNLqn3ikkAL7cD9GWgvhEKIplUHmcnQ8pbwW/WIP72Bw YEdXFIH2SRssAR4T8EJZqFkn6J4FUlgJw0xocQQkQ1DpXx4c8wWkgjKbQli6qqCuvmuS ZwZpkAZ0paSA36uP1efLgCoK9nIvJRE9V8b45isJMoBKqXfa6lAkVWFcUZIiusZFClb8 4TByqq8Fd0P2bHvINTx0s/rsPb1SzFyIi+zb8PIHlD4E/JQmnjdKRw1RiNqjPse9OkV6 mQSUeeZ2CCiszJmw6H1CD/hn64bCSBk+55xDKjBeTfgP8qZF68cyDit0u2wX4yyA/sjX JbHg== X-Gm-Message-State: AC+VfDyJNGhIrBGkPvTFFWT3HjQFndrFWJXlPKYFIW2JPh0qHZv76Ic6 VUXrA2s2Hb5GiL2uRjOaIhiLOg== X-Google-Smtp-Source: ACHHUZ7ScGensczh9UmuyiYp/ZmlB8io+k/qBQlpdUY4rc8KVOLsoQeengcc/ZPrOvpGIxvSYnF+xw== X-Received: by 2002:a05:6a00:2313:b0:636:f5f4:5308 with SMTP id h19-20020a056a00231300b00636f5f45308mr12273686pfh.7.1686587899316; Mon, 12 Jun 2023 09:38:19 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x53-20020a056a000bf500b0064ff643f954sm4274pfu.88.2023.06.12.09.38.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 09:38:19 -0700 (PDT) Date: Mon, 12 Jun 2023 09:38:17 -0700 From: Stephen Hemminger To: Matan Azrad Cc: dev@dpdk.org, Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Konstantin Ananyev , Olivier Matz Subject: Re: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO Message-ID: <20230612093817.3a69b468@hermes.local> In-Reply-To: <1565103383-23864-2-git-send-email-matan@mellanox.com> References: <1565103383-23864-1-git-send-email-matan@mellanox.com> <1565103383-23864-2-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 6 Aug 2019 14:56:23 +0000 Matan Azrad wrote: > The API breakage is because the ``tso_segsz`` field was documented for > LRO. > > The ``tso_segsz`` field in mbuf indicates the size of each segment in > the LRO packet in Rx path and should be provided by the LRO packet > port. > > While the generic LRO packet may aggregate different segments sizes in > one packet, it is impossible to expose this information for each segment > by one field and it doesn't make sense to expose all the segments sizes > in the mbuf. > > A new field may be added as union with the above field to expose the > number of segments aggregated in the LRO packet. > > Signed-off-by: Matan Azrad I assume LRO worked out how to use dynamic field for this. And the rest of this patchset is no longer relevant.