From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4673442C50;
	Mon, 12 Jun 2023 18:56:44 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C0B58410DD;
	Mon, 12 Jun 2023 18:56:43 +0200 (CEST)
Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com
 [209.85.210.174])
 by mails.dpdk.org (Postfix) with ESMTP id A58B940698
 for <dev@dpdk.org>; Mon, 12 Jun 2023 18:56:42 +0200 (CEST)
Received: by mail-pf1-f174.google.com with SMTP id
 d2e1a72fcca58-652699e72f7so3578442b3a.3
 for <dev@dpdk.org>; Mon, 12 Jun 2023 09:56:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686589001;
 x=1689181001; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=cgI28bCRqdp3+O+Jx433DqRn9pIGyOZ8daheYSSo3sA=;
 b=shutoXTH8OWkUSUKTvh0s52jH6E0q/MVuEMLIDvH0xszcDsFVTas2EfPKSLN6uxOP6
 oRoXjIeSji9NPhD2W264YmqWeWrqOjQDYZQ2KUpFLK1NurUEPPsjmWKkoOYSWEVf3a42
 QBMtuHH+bNh/OEr9pldACMcyiP8sbYDx5rmWqb+D/awLdIXPXyCyH2eW3ZaVpsBid4k4
 4Bals0orNpg1CDdALBPHB/wzkn3sda/afsXwvsjfIAsKze4g3ahd6wHPvl6NUCrna7oL
 zSIO6uISsCzkUflFvK7eKS5q+kFYsooG1oBm7EU/0/WtOwi2mAhb57OHdZ7rtC+ERJ2t
 9xAQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1686589001; x=1689181001;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=cgI28bCRqdp3+O+Jx433DqRn9pIGyOZ8daheYSSo3sA=;
 b=R691iZuAtRg0DTX4IuuV3DSNONdzoGtk3JoajhO2CXpguvT5uHqgs6h+/UJ0xF0PWb
 7G8cFRuorJ83GwBZotApxF7ClhtKUx6zjfTAGKUG5muX7/kvTCp9gRLGCyZeH5VVZClp
 fZHUOk9MmnY9OHN3H9AgnVSYG5d9JDm8JB6YJY4yZTuVczSc3kkc8ckzmIPqaw7bh2UF
 4eKrxBU3MdikngRsDFXf5/CXt8vplABTVsjcIWh8DYDva1BtmVy6tyYyL3ZBFbOiNARX
 5/9yixtZZAaCth2MgSv6Q/jM8WOoo3KQFt9pKyud09fueY2vj52Wj5/B6/4ZOS6izypB
 DwWQ==
X-Gm-Message-State: AC+VfDyPr+qJhNHBDTZUJWolGP50ReEPzZmGlugDNIZvSx9f4uhvD9Tq
 xWhF5b3SbIk46U4lGBb4vMen2A==
X-Google-Smtp-Source: ACHHUZ6xcI0SRsUDXG2KVkceF0t9rdnXkJpY8OynLSVzgoKPSTKRDpZ5GsT8zWTNvXFVu6aPRdoYWA==
X-Received: by 2002:a05:6a21:999d:b0:10c:2c30:4780 with SMTP id
 ve29-20020a056a21999d00b0010c2c304780mr10672329pzb.33.1686589001528; 
 Mon, 12 Jun 2023 09:56:41 -0700 (PDT)
Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])
 by smtp.gmail.com with ESMTPSA id
 u9-20020aa78489000000b006589cf6d88bsm7369714pfn.145.2023.06.12.09.56.40
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 12 Jun 2023 09:56:41 -0700 (PDT)
Date: Mon, 12 Jun 2023 09:56:39 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Sunil Kumar Kori <skori@marvell.com>
Cc: Muhammad Bilal <m.bilal@emumba.com>, "declan.doherty@intel.com"
 <declan.doherty@intel.com>, "tomasz.kantecki@intel.com"
 <tomasz.kantecki@intel.com>, "Pavan Nikhilesh Bhagavatula"
 <pbhagavatula@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "jgrajcia@cisco.com" <jgrajcia@cisco.com>, "vipin.varghese@intel.com"
 <vipin.varghese@intel.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free
 resources in case of error
Message-ID: <20230612095639.1f62fc15@hermes.local>
In-Reply-To: <BYAPR18MB262957B2CCB083F891A28B49B49D0@BYAPR18MB2629.namprd18.prod.outlook.com>
References: <20200519085444.4562-1-m.bilal@emumba.com>
 <BY5PR18MB3105DA2A2C084E4D488E1ABAB4B90@BY5PR18MB3105.namprd18.prod.outlook.com>
 <CAOFC0T3jT0+mZegRSYWLJ-b21CZwFk=G3pesOLFb-+XCmfLL+g@mail.gmail.com>
 <BY5PR18MB3105A40B5F6350EE6322662DB4830@BY5PR18MB3105.namprd18.prod.outlook.com>
 <CAOFC0T1s4PGQq_G15Mqzh3DxbkEhjKT7zOWWmXZOsTSrZE4Sag@mail.gmail.com>
 <BYAPR18MB26297745D4E89681EC93C624B49D0@BYAPR18MB2629.namprd18.prod.outlook.com>
 <CAOFC0T2MXBr91kq7=rMpvenYHiXAKHBbavSRJWpCGYcakLAyPg@mail.gmail.com>
 <BYAPR18MB262957B2CCB083F891A28B49B49D0@BYAPR18MB2629.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, 16 Jun 2020 10:38:01 +0000
Sunil Kumar Kori <skori@marvell.com> wrote:

> >> >> >>
> >> >> >> Also I think, it is better to release the relevant resources on error.  
> >> >> >Here I'm solving the problem reported in bugzilla id 437. The bug
> >> >> >was that if we use --vdev=net_memif with l2fwd application (and
> >> >> >with its other variants) then a socket is created by memif PMD,
> >> >> >after rte_eal_init function has run successfully. And if an error
> >> >> >occurs then the application exits without freeing the resources
> >> >> >(socket). On running the application 2nd time we get an error of "socket  
> >already exists". 

Bottom line: Fix memif, don't wallpaper over the bug by fixing the examples.

Other user applications, can and do crash. The driver needs to be robust
and handle that.