From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6E0642CAC; Wed, 14 Jun 2023 04:37:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD60D42D49; Wed, 14 Jun 2023 04:37:23 +0200 (CEST) Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56]) by mails.dpdk.org (Postfix) with ESMTP id 1187F42D46; Wed, 14 Jun 2023 04:37:19 +0200 (CEST) X-QQ-mid: bizesmtp73t1686710234twlp4e00 Received: from wxdbg.localdomain.com ( [183.159.171.58]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 14 Jun 2023 10:37:14 +0800 (CST) X-QQ-SSF: 01400000000000J0Z000000A0000000 X-QQ-FEAT: +oIWmpEafD/wskLuMHBH60FnOWGcU7m4xQ6LkUNFS7Sz/4Dxbgt4KYTo6yimZ B5Nr2A7AosS6DX5zY14SxQH2jnYhQGYSV13LGbkFaT/uS70GRcJrK19Rv7r77LLa0HwupXk Fmh34DNN8oQFTTUVHZzfxpv7ResHAb/KZvwGsEGe+HJZkqwYRs8lvR+qkgk13ADb1eothO6 1yBISecrmwovfNRNy7Bzg2OZHSuRihHXvon+v/o0eHJCT9QdnQ1RTmO5VDTvEV8y+/FbG9I c6wpt5YLgKMgMIKT9O1XA8J2ue25Hhnz6CO3goc2vBGe/oqVvNBJwTJP61la5OWU5sdUETz dMfekX2mb5Z1DVWHu4vM4m7UL6tASDaLKBLNUxEBRTRrVUwcXx5a9v9/2pnDDz6NZwrrtlZ X-QQ-GoodBg: 2 X-BIZMAIL-ID: 16514032978099383082 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 7/9] net/ngbe: fix issues caused by MNG veto bit setting Date: Wed, 14 Jun 2023 10:34:27 +0800 Message-Id: <20230614023429.1002071-8-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230614023429.1002071-1-jiawenwu@trustnetic.com> References: <20230614023429.1002071-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In the new firmware, MNG veto bit is set by default for new features. It causes the PHY configuration not to be reset after LAN reset. So PHY power will be down after stopping device. The internal PHY then cannot be initialized successfully at device start. Add setting power on for internal PHY to fix this issue. Fixes: abea8974c7a6 ("net/ngbe: support link down/up") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_phy_rtl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ngbe/base/ngbe_phy_rtl.c b/drivers/net/ngbe/base/ngbe_phy_rtl.c index 9b323624ec..88bacec114 100644 --- a/drivers/net/ngbe/base/ngbe_phy_rtl.c +++ b/drivers/net/ngbe/base/ngbe_phy_rtl.c @@ -120,6 +120,8 @@ s32 ngbe_init_phy_rtl(struct ngbe_hw *hw) hw->init_phy = true; msec_delay(1); + hw->phy.set_phy_power(hw, true); + for (i = 0; i < 15; i++) { if (!rd32m(hw, NGBE_STAT, NGBE_STAT_GPHY_IN_RST(hw->bus.lan_id))) -- 2.27.0