* [PATCH] bus/cdx: Remove ineffective code statement
@ 2023-06-14 10:22 Abhijit Gangurde
2023-06-15 9:35 ` Nipun Gupta
0 siblings, 1 reply; 2+ messages in thread
From: Abhijit Gangurde @ 2023-06-14 10:22 UTC (permalink / raw)
To: Nipun.Gupta, nikhil.agarwal
Cc: dev, david.marchand, ferruh.yigit, Abhijit Gangurde
ret = 0 statement is ineffective since it is overwritten in a loop.
Coverity issue: 385379
Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus")
Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
---
drivers/bus/cdx/cdx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c
index 28bbf92ed5..9130c30515 100644
--- a/drivers/bus/cdx/cdx.c
+++ b/drivers/bus/cdx/cdx.c
@@ -452,7 +452,6 @@ cdx_probe(void)
dev->name);
rte_errno = errno;
failed++;
- ret = 0;
}
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] bus/cdx: Remove ineffective code statement
2023-06-14 10:22 [PATCH] bus/cdx: Remove ineffective code statement Abhijit Gangurde
@ 2023-06-15 9:35 ` Nipun Gupta
0 siblings, 0 replies; 2+ messages in thread
From: Nipun Gupta @ 2023-06-15 9:35 UTC (permalink / raw)
To: Abhijit Gangurde, nikhil.agarwal; +Cc: dev, david.marchand, ferruh.yigit
Acked-by: Nipun Gupta <nipun.gupta@amd.com>
On 6/14/2023 3:52 PM, Abhijit Gangurde wrote:
> ret = 0 statement is ineffective since it is overwritten in a loop.
>
> Coverity issue: 385379
> Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus")
> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
> ---
> drivers/bus/cdx/cdx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c
> index 28bbf92ed5..9130c30515 100644
> --- a/drivers/bus/cdx/cdx.c
> +++ b/drivers/bus/cdx/cdx.c
> @@ -452,7 +452,6 @@ cdx_probe(void)
> dev->name);
> rte_errno = errno;
> failed++;
> - ret = 0;
> }
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-15 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-14 10:22 [PATCH] bus/cdx: Remove ineffective code statement Abhijit Gangurde
2023-06-15 9:35 ` Nipun Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).