From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8792342CBA; Wed, 14 Jun 2023 21:10:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D4D840E0F; Wed, 14 Jun 2023 21:10:43 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id B3B1240DDB for ; Wed, 14 Jun 2023 21:10:41 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1b3be39e666so188475ad.0 for ; Wed, 14 Jun 2023 12:10:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686769841; x=1689361841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HaQbiNdFdSL2ywtZ36Z6bME0tn7VNjmhAlPWZrgCUCg=; b=CpRaSh+ZWn0PAyCD6Pznax12oq3cnNK1wCRijennjCHZH4U9lUQNMBcOLv2KlOi4Cq Z74S1PDVSAHMsYYxO678LjBkEDHONr1yaSpFMToyqEp2Wi+w+woKiDrkk3deDdrBL+79 5Jge1U2ixHMOCIrtHireCosbdySk/Gv3BWLle+5Jjo9iRTrFL+N7ktzKCoTWn+Ei4ywo wEGtaaners+CoZxERqonVlwuU/ynGeolokcBiKwvuddcVTrCyN62mAvidZyDMc59L3a1 cDQVY736lXy3fgiU3SggUE5pJ5yBXQ5MVtoGt/PIWGSU0DvRDxwG5UGIAsnsWHZpy1qt aypQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686769841; x=1689361841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HaQbiNdFdSL2ywtZ36Z6bME0tn7VNjmhAlPWZrgCUCg=; b=XSIwAJJpbtsnxfc/bLQTInbv4RmqI6ZUTmwsJ6Ki+6rl7QfJPUQRB69drKk7prEtxs hZ8vlwbskUSSn8b7E/DjRDcnZMBTf345HO9vtosyA6e0kJ2Os59uwpc2vSYqZ5BzTg+U svGHYQDKBpj6+WD9evrR0RMrfm56rHfp4h2WupjGVvrYK/rdrgjP00xgXSxmT6Bs99PW TJZIIDk7exfOunLsjYtjXzfiynS3A4VOMlc/c1nNTG04sBMCidXtCHYfq+nkEIiblFSB DXfM40EVzpL6S87rPHrvIlu+IXu7GoxhtPdfsFFYW1gfMD5T4fLK+EjSoAOWui057zTP H8OQ== X-Gm-Message-State: AC+VfDypAuod0mb5lmzCKjGnovnzW7PSn7YBdr6tip4wsox25FZoMCut DYNYUg4tc5b6SactzwXOvTyBpw== X-Google-Smtp-Source: ACHHUZ64FGOOnlEBSKZeNRbTFdCz5mzOXgx2+943qjOR9lAOUyGxLTxeSWWo7sO+3YwmJQEScSfYRQ== X-Received: by 2002:a17:903:1c7:b0:1b2:544b:3d54 with SMTP id e7-20020a17090301c700b001b2544b3d54mr3694993plh.17.1686769840798; Wed, 14 Jun 2023 12:10:40 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id x1-20020a170902b40100b001a804b16e38sm12538511plr.150.2023.06.14.12.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 12:10:40 -0700 (PDT) Date: Wed, 14 Jun 2023 12:09:51 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: Mohammed Hawari , dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/1] build: allow disabling libs Message-ID: <20230614120945.3e386d16@hermes.local> In-Reply-To: <20200918135750.GA1592@bricha3-MOBL.ger.corp.intel.com> References: <20200918084924.31784-1-mohammed@hawari.fr> <20200918084924.31784-2-mohammed@hawari.fr> <20200918114329.GA1589@bricha3-MOBL.ger.corp.intel.com> <33FE1BDE-C31E-4879-836B-DA22C850B829@hawari.fr> <20200918135750.GA1592@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 18 Sep 2020 14:57:50 +0100 Bruce Richardson wrote: > On Fri, Sep 18, 2020 at 02:54:21PM +0200, Mohammed Hawari wrote: > > Hello Bruce, > > > > Thanks for the quick response, see inline > > > > Best regards, > > > > Mohammed > > > > > On 18 Sep 2020, at 13:43, Bruce Richardson wrote: > > > > > > On Fri, Sep 18, 2020 at 10:49:23AM +0200, Mohammed Hawari wrote: > > >> Similarly to the disable_drivers option, the disable_libs option is > > >> introduced. This allows to selectively disable the build of elements > > >> in libs to speed-up the build process. > > >> > > >> Signed-off-by: Mohammed Hawari > > >> --- > > > > > > While I don't particularly like allowing libs to be enabled and disabled > > > since it complicates the build, I can see why it's necessary. This is an > > > area that does need some discussion, as I believe others have some opinions > > > in this area too. > > > > > > However, for now, some additional thoughts, both on this patch and in > > > general: > > > > > > 1. I see you included disabling apps if their required libs are not > > > available. What about the drivers though? > > To my understanding, in the current code, the drivers/meson.build file already > > does that check with: > > > > foreach d:deps > > if not is_variable('shared_rte_' + d) > > build = false > > > > Yes, my mistake, I forgot that that was added as one driver could depend > upon another. :-( > > > > 2. A bigger issue is whether this is really what we want to do, guarantee a > > > passing build even if vast chunks of DPDK are actually enabled? I'd tend > > > towards "no" in this case, and I'd rather see disabling of libs more > > > constrained. > > > 3. To this end, I think I'd rather see us maintain a set of libs which are > > > allowed to be disabled, and prevent the rest from being so. For example, > > > it makes no sense in DPDK to disable the EAL or mempool libs, since nothing > > > will build, while the bitrate_stats or latency_stats libs could likely > > > be disabled with little or no impact. > > I tend to agree with that more structured approach, but I am going to wait until > > we get some more thoughts from the community before starting that work. > > > > That seems a wise approach. If there is no consensus after a while here, it > probably needs to go to the technical board. Marking current patch as "Changes requested". Assume that if someone wants to go further then and propose a more targeted build setting. Something like minimal??