From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 853C342CBA; Wed, 14 Jun 2023 21:33:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17FC840E0F; Wed, 14 Jun 2023 21:33:15 +0200 (CEST) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id CC90A40DDB for ; Wed, 14 Jun 2023 21:33:13 +0200 (CEST) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6668208bd4eso417181b3a.0 for ; Wed, 14 Jun 2023 12:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1686771193; x=1689363193; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=tv6fI2nA2VwQVI/mFaNIwMz100ihNJ43Xro+DPNual8=; b=DeiXwo5bQZGAqpseTHH8rmyHiPnF3FV/DHdz/kmB45l1z7mwIbI233gs41+JR5Ht4b yxdOdThdd79D8hJfB7QZcHcYSGCXrYJ/QMP5qcej3pFGzq/NGGbrJfbczJdWB9+bkegY EBhfjE9L0sB6Ua06ywenhRAf2ZiHyJUFDPHo/pIsRhCp22RQJyrRpZ9BZtM9Ghj2i31t n6p7q+GLtcOiOFGYqd+SG4k96BUkpk7mH2WCJdovz0C/Z+EXO5DdPp0vHPokvXSxDqRq zfYwZYBYk9WDB56ijnSce51GJ1JRgX1lWNUuHWqxQcTf78eFX6z21NMS1wPYYW4w5DZM KZ6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686771193; x=1689363193; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tv6fI2nA2VwQVI/mFaNIwMz100ihNJ43Xro+DPNual8=; b=iHh9lK48S/lK8IZIUVCKoZNzo6kKTa3eLykm8Y5mU2P2QWTCY2MmtvrwBBWoML/uWM t6Ccz6MCjScnrXmA9YDI+cwJdS6xMiBIyqwhfKjqVTbagESHapiaX0PHOiau/ZbLsE9p O7+2SLfV4a1FEBPLpEZ26xSgc1FhNKb1atIfHVWeqGk0FmqwiuK368Z/H+ZYqAlTF184 NVf2yX9x6ijmcgAhCEWcCcOrDrQolAepJcCSoVLBMKb9GUh0lEuV5uapOKwjY1+90sY6 t5OW9MBqLiysT1f/AK1/Tp11CL2p6nUXKy2zrJftTQqQg3PP2r9qRn9PXvvjaMNTseO+ IrVQ== X-Gm-Message-State: AC+VfDzjDxRiKYzn+DPMBNqcwz0YzjPSDwa/Q/cOt4M3qZWQ6YhTo6aG PP4JTwbkdcLn+M39UCEgkuUVCg== X-Google-Smtp-Source: ACHHUZ4yGSspypCunb7vVA+HIBV0QUqFae69FQVjU+kQEP/U6fcPam/6vsSfHnFXrddlxXPG+xyyZg== X-Received: by 2002:a05:6a20:6a0b:b0:110:2e00:3d59 with SMTP id p11-20020a056a206a0b00b001102e003d59mr3287453pzk.23.1686771192876; Wed, 14 Jun 2023 12:33:12 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id k30-20020a63ba1e000000b0054febe8a5f6sm247077pgf.82.2023.06.14.12.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 12:33:12 -0700 (PDT) Date: Wed, 14 Jun 2023 12:33:10 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org, bluca@debian.org, david.marchand@redhat.com, ian.stokes@intel.com, Ilya Maximets , Jerin Jacob , Ruifeng Wang , Honnappa Nagarahalli , David Christensen Subject: Re: [dpdk-dev] [RFC PATCH] build/pkg-config: remove machine arch flag Message-ID: <20230614123310.710fa9e0@hermes.local> In-Reply-To: <20201211155111.145279-1-bruce.richardson@intel.com> References: <20201211155111.145279-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 11 Dec 2020 15:51:11 +0000 Bruce Richardson wrote: > Traditionally any apps built using DPDK had to support the same > instruction sets as supported when the DPDK SDK itself was built, since > that was "leaked" through to the end-app and DPDK headers via > RTE_MACHINE_CPUFLAG_* values. Therefore, when converting over to meson > for app build correctness the "-march=" flag was included in the > pkg-config cflags output. > > However, since the DPDK-specific CPU flags are now obsolete, and we > instead check directly for compiler-defined flags, we should no longer > need to force the exact same architecture match in all cases. To > faciliate such flexibility, a new pkg_config_machine_args array - which > defaults to the existing machine_args array has been defined. The > individual architectures - x86, arm and ppc - can choose if and how to > override this value themselves. > > For x86, since SSE4.2 is the minimum instruction-set level needed to run > DPDK, and since some header files assume that minimum level of > instruction set support, we override the "-march=" value with "-msse4" > for the pkg-config file. This allows end applications to set their own > "march" value while still ensuring valid DPDK compilation. > > Signed-off-by: Bruce Richardson This looks fine, and can see no negatives in the comments. Could you rebase and resubmit a new version if still relevant?