From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBAF342CC2; Thu, 15 Jun 2023 09:07:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B08C240DDA; Thu, 15 Jun 2023 09:07:59 +0200 (CEST) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 5857540A84 for ; Thu, 15 Jun 2023 09:07:58 +0200 (CEST) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6668b13c7daso165476b3a.1 for ; Thu, 15 Jun 2023 00:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1686812877; x=1689404877; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kxHBFmPlbmTV9jJbbrApTftVRUunANp/bJBwRiUtVlY=; b=UqrB51Np4k+RlOt3pigAV4ID6kX/z2spP2nngtyBdQ4PxaU/OYffMbCrFL+Aei853j /dUcrBMd8pfbnvWmX6g9l0SUrDYQXIsKXcRF8km83zduLTUQkcIMNP6I1Plqmy/+8k1L LVB9atSZHgJdlwxaWjJ1VxmzLm1zxo98wIBcbfX7E8y0MZiJCAN0F1OX3sSjL7jhW7G8 zBmPFmCcQi7WPQqnbwIrLVwRVVxqoYlgFw2GlUP8wS+d3GI+H5qQg940lr8Pbk3f4n4y FA1DXSZu/QqC6NC1A9hhXaDztZEOyzHFF1eoqvOhEV98EnN/lr5C3JjMdQBmbEb3aMGJ ZSTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686812877; x=1689404877; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kxHBFmPlbmTV9jJbbrApTftVRUunANp/bJBwRiUtVlY=; b=a6O6DW52JzJuhQOK0Tv7IWVCYkKzs//XvCHTqfFfRAsHTmf6Ymi9OHczmhFtIqCiHD 4bXJoL2iNxPfZLPiSkD8UtTUtZlaXW9CYBKnVRadiFDCM6UlKQTQPtCMP5w1vox/T5Az Yk88p0Jzje4BBBFVy1EydbFgOTrmz05lubDG04apJpG7n80spRlANPLypkr0Fv13VpQx J69h8rB5VMk5EgLYCon3Qx3cTjCj55b2pp677M7ryr0Lrs2WM4gvWIaalVXvq8YzVRv6 MtEKasxGTF3lQZvKtxLOabTlPETNg3HXkoQZLCZxlYfohwqABff/td+azfOkKz5DsbrO fBpA== X-Gm-Message-State: AC+VfDzNbIsmpahpi10KOnZbwzfeykoEKkgcH3VIt+fTrGrL7y9zVJL3 oOAuES5FHWe4pvvoCgdQ6CE2hA== X-Google-Smtp-Source: ACHHUZ6H59R0eOEfVUygJ3TRzOcmw7F/cRyToIxQmaJ+GLNMPkmK6ewf6IcCmRaKAxxMVnDS/bH8Ag== X-Received: by 2002:a05:6a00:4210:b0:662:2d7a:7c68 with SMTP id cd16-20020a056a00421000b006622d7a7c68mr20216029pfb.2.1686812877514; Thu, 15 Jun 2023 00:07:57 -0700 (PDT) Received: from HTW5T2C6VL.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id b2-20020aa78702000000b006668f004420sm717941pfo.148.2023.06.15.00.07.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 15 Jun 2023 00:07:57 -0700 (PDT) From: Fengnan Chang To: david.marchand@redhat.com, anatoly.burakov@intel.com, dev@dpdk.org Cc: Fengnan Chang Subject: [PATCH v2] eal: fix prompt info when remap_segment failed Date: Thu, 15 Jun 2023 15:07:44 +0800 Message-Id: <20230615070744.93340-1-changfengnan@bytedance.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When there is not enough space to memsegs, we should prompt which configuration should be modified instead of printing some numbers. Signed-off-by: Fengnan Chang --- lib/eal/freebsd/eal_memory.c | 5 ++--- lib/eal/linux/eal_memory.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/eal/freebsd/eal_memory.c b/lib/eal/freebsd/eal_memory.c index 17ab10e0ca..41456fa9c2 100644 --- a/lib/eal/freebsd/eal_memory.c +++ b/lib/eal/freebsd/eal_memory.c @@ -172,9 +172,8 @@ rte_eal_hugepage_init(void) break; } if (msl_idx == RTE_MAX_MEMSEG_LISTS) { - RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase %s and/or %s in configuration.\n", - RTE_STR(RTE_MAX_MEMSEG_PER_TYPE), - RTE_STR(RTE_MAX_MEM_MB_PER_TYPE)); + RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase RTE_MAX_MEMSEG_PER_LIST " + "RTE_MAX_MEMSEG_PER_TYPE and/or RTE_MAX_MEM_MB_PER_TYPE in configuration.\n"); return -1; } arr = &msl->memseg_arr; diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c index 0876974631..6674db0ff5 100644 --- a/lib/eal/linux/eal_memory.c +++ b/lib/eal/linux/eal_memory.c @@ -716,9 +716,8 @@ remap_segment(struct hugepage_file *hugepages, int seg_start, int seg_end) break; } if (msl_idx == RTE_MAX_MEMSEG_LISTS) { - RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase %s and/or %s in configuration.\n", - RTE_STR(RTE_MAX_MEMSEG_PER_TYPE), - RTE_STR(RTE_MAX_MEM_MB_PER_TYPE)); + RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase RTE_MAX_MEMSEG_PER_LIST " + "RTE_MAX_MEMSEG_PER_TYPE and/or RTE_MAX_MEM_MB_PER_TYPE in configuration.\n"); return -1; } -- 2.37.1 (Apple Git-137.1)