From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E8F9742CCA;
	Thu, 15 Jun 2023 22:14:21 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E275442C24;
	Thu, 15 Jun 2023 22:14:06 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 5E57A410D0
 for <dev@dpdk.org>; Thu, 15 Jun 2023 22:14:05 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 821E220FEA59; Thu, 15 Jun 2023 13:14:04 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 821E220FEA59
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1686860044;
 bh=rMMhB8oc0CV79g+AF+d718RN2/CfDxcBqCayOLSQUU4=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=Mg757vc/wkeJbstsijOyx0XY5mY0u7LrNUCYeGGxdz9ys8hAkIRuf3tKmIUcOrvy/
 48xTSID0q0s2JOzfmHIufYhxaE584oQeYHOecHgDBqd0fl3CGwY9Ob0zMmWOgyb1Ic
 s5Ixz52BXOBc+bOP7Upi3TccC9IK6c3vukAsOuvI=
Date: Thu, 15 Jun 2023 13:14:04 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: prateekag@cse.iitb.ac.in, dev@dpdk.org
Subject: Re: [PATCH] app: do not call printf in signal handlers
Message-ID: <20230615201404.GB32486@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20201204175151.11868-1-pratekag@gmail.com>
 <20230613001150.65407-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230613001150.65407-1-stephen@networkplumber.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Jun 12, 2023 at 05:11:50PM -0700, Stephen Hemminger wrote:
> Using printf is not async-signal safe and worst case may lead to deadlock.
> Remove printf from signal handlers present in several applications.
> 
> Testpmd was already fixed by
> commit 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal")
> 
> Signed-off-by: Prateek Agarwal <prateekag@cse.iitb.ac.in>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>