From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA7F342CCA; Thu, 15 Jun 2023 22:24:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4188740E0F; Thu, 15 Jun 2023 22:24:49 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 303F340A8B for ; Thu, 15 Jun 2023 22:24:47 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 76A4C20FEB78; Thu, 15 Jun 2023 13:24:46 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 76A4C20FEB78 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1686860686; bh=S2YYQgo9ZmDsYE0qdTZ7WW4Qqz0EOmc5y3MzdjE1hMQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pZGlTVnxNy0G644/2cDLyZthFybZxQnsmtiHX773HMqylkZnqwj0vFItdyUsP8oNU zss23V+W9ZaLfx+PQEcx9fxGaX1vmNIjy0sR0TFwV0mq6gB01cP4MlDkXQgeaKxWwD p5FATrmQbXYdvZtsFnz8y9qlsER2w5SulNZRIpn4= Date: Thu, 15 Jun 2023 13:24:46 -0700 From: Tyler Retzlaff To: Bruce Richardson Cc: dev@dpdk.org Subject: Re: [PATCH] buildtools: remove assumption about current work dir Message-ID: <20230615202446.GC32486@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230614144728.481566-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230614144728.481566-1-bruce.richardson@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 14, 2023 at 03:47:28PM +0100, Bruce Richardson wrote: > According to meson documentation, we should not make any assumptions as > to what directory a script is called from[1]. The use of "relpath" when > processing the output of directory globbing is therefore unsafe, as it > was stripping off paths relative to the current directory - which just > happened to be the same as the root directory we were processing. > > To improve safety, and support meson clones (like muon) which > don't always run things from the currently processed path, we need to > explicitly specify that the start parameter for relpath() should be > "root" value. > > [1] https://mesonbuild.com/Reference-manual_functions.html#run_command > > Signed-off-by: Bruce Richardson > --- Reviewed-by: Tyler Retzlaff