DPDK patches and discussions
 help / color / mirror / Atom feed
From: Matthew Smith <mgsmith@netgate.com>
To: junfeng.guo@intel.com, simei.su@intel.com
Cc: dev@dpdk.org, Matthew Smith <mgsmith@netgate.com>
Subject: [PATCH] net/igc: disable EEE by default on I225/226
Date: Tue, 20 Jun 2023 14:56:09 +0000	[thread overview]
Message-ID: <20230620145609.3572125-1-mgsmith@netgate.com> (raw)

I226-V devices can hang when EEE is enabled. Explicitly disable
EEE during initialization of the device, as the Linux and FreeBSD
kernel drivers do.

Signed-off-by: Matthew Smith <mgsmith@netgate.com>
---
 drivers/net/igc/base/igc_i225.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c
index 180d3cf687..17a1573064 100644
--- a/drivers/net/igc/base/igc_i225.c
+++ b/drivers/net/igc/base/igc_i225.c
@@ -122,6 +122,9 @@ static s32 igc_init_mac_params_i225(struct igc_hw *hw)
 
 	mac->ops.write_vfta = igc_write_vfta_generic;
 
+	/* Disable EEE by default */
+	dev_spec->eee_disable = true;
+
 	return IGC_SUCCESS;
 }
 
@@ -1243,6 +1246,7 @@ s32 igc_init_hw_i225(struct igc_hw *hw)
 
 	hw->phy.ops.get_cfg_done = igc_get_cfg_done_i225;
 	ret_val = igc_init_hw_base(hw);
+	igc_set_eee_i225(hw, false, false, false);
 	return ret_val;
 }
 
-- 
2.30.1 (Apple Git-130)


             reply	other threads:[~2023-06-20 14:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 14:56 Matthew Smith [this message]
2023-06-21  0:52 ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230620145609.3572125-1-mgsmith@netgate.com \
    --to=mgsmith@netgate.com \
    --cc=dev@dpdk.org \
    --cc=junfeng.guo@intel.com \
    --cc=simei.su@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).