From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C113A42D09; Tue, 20 Jun 2023 16:57:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4684B410D7; Tue, 20 Jun 2023 16:57:02 +0200 (CEST) Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by mails.dpdk.org (Postfix) with ESMTP id 1A6AA40EDF for ; Tue, 20 Jun 2023 16:57:01 +0200 (CEST) Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-6b58558c824so1624324a34.0 for ; Tue, 20 Jun 2023 07:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netgate.com; s=google; t=1687273020; x=1689865020; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WpE9p7q8iQyDYTmF8SMUQIEkOQplB1ZlCKOs0cIezig=; b=gPU5lXhigjy7o6iYnjYR2ZLSEQtKFqUQvbPhZYoiwCfWtOd9OlMfHg8FtwZol1VfMv iosUwZQTs7+WnIPb6/hyZhra7BcHk2qyuSJFB0/7g0BLJiKp6r+9CmmJ0cNjPR5WjbPR DobJH4w8cuvmAlv2D3l8drzaYHQyRTTXxMYnc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687273020; x=1689865020; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WpE9p7q8iQyDYTmF8SMUQIEkOQplB1ZlCKOs0cIezig=; b=PCsyA66RjxYv2jtzUFeBVJdQH2UfIdo92RFWxjYdvJS3hlrUxjBzV15Xrv+MI1YBXq nkOkKUpTOeBXuaAW4ls3xTQyrhDIRK/aAx30ykOnp1xxk3gNE5e/v6NWQcQL5RyjsCuk WiRMu66qRc/KEWIHBSbirLZZFML+wXm/FYvbZgGpMa5eVUlc5A1q6aXXhlhmzRGjmlED UGdFviohAW5o6esFaq9jXydFwENpeb3BK/Pkp7/Xpj+IMPB+gG0Da+cVZcOkBtugV+40 HWfh8ouo927V540UfM2rYJIRUV5S5iFpNRZv69uA2M+tkBvqyBzbw3gyTmPKkMfVF3OB TNLA== X-Gm-Message-State: AC+VfDxTYWuCSdbcse51GTjmpMdGz3KQFSsXvyIIH30S687Y846vXQvt Zn84TXmjMNb+qRnFtkUO/pKBnA== X-Google-Smtp-Source: ACHHUZ7B+Bahkaa87c4PlFA8BcbdL56p0V7o+iYYi5lj3ocUpEQ+E5wtyWSDsITXjJUCKsO6fUD7KQ== X-Received: by 2002:a9d:6e8a:0:b0:6b5:abd5:735b with SMTP id a10-20020a9d6e8a000000b006b5abd5735bmr250805otr.11.1687273020389; Tue, 20 Jun 2023 07:57:00 -0700 (PDT) Received: from xg1541-1-zcolo.netgate.com ([2610:160:11:3f:ec4:7aff:fec7:62f6]) by smtp.googlemail.com with ESMTPSA id g19-20020a9d6b13000000b006af78565d64sm1014585otp.46.2023.06.20.07.56.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 07:57:00 -0700 (PDT) From: Matthew Smith To: junfeng.guo@intel.com, simei.su@intel.com Cc: dev@dpdk.org, Matthew Smith Subject: [PATCH] net/igc: disable EEE by default on I225/226 Date: Tue, 20 Jun 2023 14:56:09 +0000 Message-Id: <20230620145609.3572125-1-mgsmith@netgate.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org I226-V devices can hang when EEE is enabled. Explicitly disable EEE during initialization of the device, as the Linux and FreeBSD kernel drivers do. Signed-off-by: Matthew Smith --- drivers/net/igc/base/igc_i225.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/igc/base/igc_i225.c b/drivers/net/igc/base/igc_i225.c index 180d3cf687..17a1573064 100644 --- a/drivers/net/igc/base/igc_i225.c +++ b/drivers/net/igc/base/igc_i225.c @@ -122,6 +122,9 @@ static s32 igc_init_mac_params_i225(struct igc_hw *hw) mac->ops.write_vfta = igc_write_vfta_generic; + /* Disable EEE by default */ + dev_spec->eee_disable = true; + return IGC_SUCCESS; } @@ -1243,6 +1246,7 @@ s32 igc_init_hw_i225(struct igc_hw *hw) hw->phy.ops.get_cfg_done = igc_get_cfg_done_i225; ret_val = igc_init_hw_base(hw); + igc_set_eee_i225(hw, false, false, false); return ret_val; } -- 2.30.1 (Apple Git-130)