From: Zhichao Zeng <zhichaox.zeng@intel.com>
To: dev@dpdk.org
Cc: qi.z.zhang@intel.com, Zhichao Zeng <zhichaox.zeng@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Zhirun Yan <zhirun.yan@intel.com>
Subject: [PATCH] net/ice: revert mark action in switch filter
Date: Wed, 21 Jun 2023 17:41:25 +0800 [thread overview]
Message-ID: <20230621094125.3071251-1-zhichaox.zeng@intel.com> (raw)
This implementation has some problem, the function did not work properly,
and it broke the mark action in FDir filter, so revert this commit.
Fixes: e24f43f2c824 ("net/ice: support flow mark action in switch")
Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
drivers/net/ice/ice_switch_filter.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
index 1ff4b1afda..110d8895fe 100644
--- a/drivers/net/ice/ice_switch_filter.c
+++ b/drivers/net/ice/ice_switch_filter.c
@@ -1715,7 +1715,6 @@ ice_switch_parse_action(struct ice_pf *pf,
struct rte_eth_dev_data *dev_data = pf->adapter->pf.dev_data;
const struct rte_flow_action_queue *act_q;
const struct rte_flow_action_rss *act_qgrop;
- const struct rte_flow_action_mark *act_mark;
uint16_t base_queue, i;
const struct rte_flow_action *action;
enum rte_flow_action_type action_type;
@@ -1768,13 +1767,6 @@ ice_switch_parse_action(struct ice_pf *pf,
ICE_DROP_PACKET;
break;
- case RTE_FLOW_ACTION_TYPE_MARK:
- act_mark = action->conf;
- rule_info->sw_act.fltr_act =
- ICE_SET_MARK;
- rule_info->sw_act.markid = act_mark->id;
- break;
-
case RTE_FLOW_ACTION_TYPE_VOID:
break;
@@ -1830,7 +1822,6 @@ ice_switch_check_action(const struct rte_flow_action *actions,
case RTE_FLOW_ACTION_TYPE_RSS:
case RTE_FLOW_ACTION_TYPE_QUEUE:
case RTE_FLOW_ACTION_TYPE_DROP:
- case RTE_FLOW_ACTION_TYPE_MARK:
case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT:
case RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR:
actions_num++;
--
2.34.1
next reply other threads:[~2023-06-21 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 9:41 Zhichao Zeng [this message]
2023-06-25 2:19 ` Yan, Zhirun
2023-06-25 2:35 ` Zeng, ZhichaoX
2023-06-25 6:21 ` [PATCH v2] " Zhichao Zeng
2023-07-03 2:35 ` Yan, Zhirun
2023-07-03 2:43 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621094125.3071251-1-zhichaox.zeng@intel.com \
--to=zhichaox.zeng@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=zhirun.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).