From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5803D42D49; Sun, 25 Jun 2023 10:40:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12D2440ED8; Sun, 25 Jun 2023 10:40:52 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 17D6040A7F; Sun, 25 Jun 2023 10:40:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687682450; x=1719218450; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=t85uv5UUciBpRJtzuHqE+897ZZ9BuU2nF3M7CXOgS+w=; b=dxOvTAajlpS4zDuVZo7HdiwaZOKK67H5YLSnciYQNVGQMRfxv98A8fjQ +BgKLZyjt6a7gHsfN+sfYDlLxHB2Ge4rl9+2GE9/Z8/leOkBF8ZJNBIqn NCP6nNKh7aKWA6XBy3lEJwTTKwRgRDE2049eSUfL+iHK8dQ0WvFZf5VgW Fut6v8GAs6xHSsPzG+ohWLW+uzpdqkNb6NKPkXrB2lkvnFZ7bCWf+Ul7K BKlil/Z+2GnvHx8+uJgKAX6Oh/hXZutfh4aPXpmAvN6MdG/WIkZTxi9ah E8RwZmYQu0BewXwtHFthEfkS98So96oGHns0Yo9diK7Iaj+mgYq508N7H g==; X-IronPort-AV: E=McAfee;i="6600,9927,10751"; a="424717268" X-IronPort-AV: E=Sophos;i="6.01,157,1684825200"; d="scan'208";a="424717268" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2023 01:40:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10751"; a="1046123213" X-IronPort-AV: E=Sophos;i="6.01,157,1684825200"; d="scan'208";a="1046123213" Received: from dpdk-qiming3.sh.intel.com ([10.67.111.4]) by fmsmga005.fm.intel.com with ESMTP; 25 Jun 2023 01:40:46 -0700 From: Qiming Yang To: qi.z.zhang@intel.com, dev@dpdk.org Cc: Qiming Yang , stable@dpdk.org Subject: [PATCH] net/ice: fix VLAN mode parser Date: Sun, 25 Jun 2023 08:23:08 +0000 Message-Id: <20230625082308.2674971-1-qiming.yang@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Parser will not be ctreated if raw packet filter is not support. This patch add NULL pointer check for parser structure when VLAN mode configure. Fixes: 6e753d777ffc ("net/ice: initialize parser for double VLAN") Cc: stable@dpdk.org Signed-off-by: Qiming Yang --- drivers/net/ice/ice_generic_flow.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c index ed3075d555..91bf1d6fcb 100644 --- a/drivers/net/ice/ice_generic_flow.c +++ b/drivers/net/ice/ice_generic_flow.c @@ -1836,10 +1836,12 @@ ice_flow_init(struct ice_adapter *ad) if (ice_parser_create(&ad->hw, &ad->psr) != ICE_SUCCESS) PMD_INIT_LOG(WARNING, "Failed to initialize DDP parser, raw packet filter will not be supported"); - if (ice_is_dvm_ena(&ad->hw)) - ice_parser_dvm_set(ad->psr, true); - else - ice_parser_dvm_set(ad->psr, false); + if (ad->psr) { + if (ice_is_dvm_ena(&ad->hw)) + ice_parser_dvm_set(ad->psr, true); + else + ice_parser_dvm_set(ad->psr, false); + } RTE_TAILQ_FOREACH_SAFE(engine, &engine_list, node, temp) { if (engine->init == NULL) { -- 2.25.1