From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C734042D5E; Mon, 26 Jun 2023 18:38:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5503840223; Mon, 26 Jun 2023 18:38:20 +0200 (CEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 7FA684013F for ; Mon, 26 Jun 2023 18:38:18 +0200 (CEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1b7fdc66e30so6568265ad.2 for ; Mon, 26 Jun 2023 09:38:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1687797497; x=1690389497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date:from:to:cc:subject:date:message-id :reply-to; bh=fjnUeUCcgdNvy3r/BIHtJtUk4giAIwFZkwVSxtVrO2w=; b=v6d5sNqvNbSW0v35dKpQpRJMhUk9spg6dQ6imbRkool4J7YILAUukjz/gtHKg4P5nY 3rY9TOM0/Q7eZrWnwQ8Jur/pkNQQnzGB4ggrrHCkWJjxKwHyFKmnT2Eo2E8cacK/v4mh x/nvPBgD+4+yNlCSTn9yAxnBuyPTW5a5Kh5Uwh3vrYtXiNBb9A3ZPfG3dtDkCbzGwMcj t35Y4+dwzvALXmyOmdc5ArB+tgmjyULXUjL0cHmNarLf4wQxoyK7CW2ZbPijHojYXD5B zKSlMxjagf+vcrxa0BvEQu/I+nTmvNbSomQ9yeZqHwuCjD15L+0SKnmRLME2gAR8oPr3 Hc5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687797497; x=1690389497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fjnUeUCcgdNvy3r/BIHtJtUk4giAIwFZkwVSxtVrO2w=; b=Mp/Vha2kKaoWc+QqcdDBSTNmoE6GPp/meKIN5DlgrEyVvOImNEZCSacE04RbxEv/9W dbkhufyVHaSD9zLLjGQYwzWS27zcJhs9uLBPYWI7Km6DAjHo8UxSwBDGhPzYpzIC0y5I dTsEfjocz+24HnpFKh2VonkkgQAmHjuwGWB1vZY8NjT3yQk+YlXPfjduwsuyEd4D1p8O dfzDsIJHDIxP01aCX0PCXbehWuG0oxn5PyOvegei2OI6EBtQQw2xVkN5rrAVITZ2QSmR 6fENCyDTLlNffAGPW7GmMyHomn0f6APokV0tVILOLb1cAqh2EG/FMMLupIXiqGqWwAsG JLcA== X-Gm-Message-State: AC+VfDzaM2tjz5OVhPXXGpnzK00+KW/ZA3L1N+89xGtrc4GRJg6Az1uN +EqbANcnfxRBnHt9mdwV29uspG+U4CT34duyhhl86A== X-Google-Smtp-Source: ACHHUZ6tybADVQeyK6r586HosAZ6/ssoZCxDKMPgk7eDHjYGYwvac6H3Z7+y6lRY2ylEsXo6zKq7CA== X-Received: by 2002:a17:903:1c1:b0:1b3:ad86:ed17 with SMTP id e1-20020a17090301c100b001b3ad86ed17mr4416138plh.9.1687797497278; Mon, 26 Jun 2023 09:38:17 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id k12-20020a170902760c00b001b246dcffb7sm4379881pll.300.2023.06.26.09.38.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 09:38:17 -0700 (PDT) Date: Mon, 26 Jun 2023 09:38:11 -0700 From: Stephen Hemminger To: dev@dpdk.org Subject: Re: [PATCH] doc: announce deprecation of cmdline_poll Message-ID: <20230626093811.178348f4@hermes.local> In-Reply-To: <20230314171858.67446-1-stephen@networkplumber.org> References: <20230314171858.67446-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 14 Mar 2023 10:18:58 -0700 Stephen Hemminger wrote: > Function was added by commit 067855e651d6 ("cmdline: add polling mode") > but never tested or used by DPDK applications. Mark it for > future removal. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/rel_notes/deprecation.rst | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 872847e938ed..28c458591a68 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -135,3 +135,8 @@ Deprecation Notices > Its removal has been postponed to let potential users report interest > in maintaining it. > In the absence of such interest, this library will be removed in DPDK 23.11. > + > +* cmdline: The function ``cmdline_poll`` does not work correctly on either > + Linux or Windows and is unused by any part of DPDK. > + It will be marked deprecated > + starting in the 23.07 relead and removed in DPDK 23.11. This patch was put out in March and should be merged for 23.07 so that the dead function can be removed in 23.11. Why the no response on this? The function was never used and if anyone did try to use it would have discovered it was broken. Should it just be removed in 23.11 without warning?