From: Stephen Hemminger <stephen@networkplumber.org>
To: Suanming Mou <suanmingm@nvidia.com>, harry.van.haaren@intel.com
Cc: <thomas@monjalon.net>, <david.marchand@redhat.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: add rte_exit() main lcore limitation description
Date: Thu, 29 Jun 2023 20:37:20 -0700 [thread overview]
Message-ID: <20230629203720.682f90c3@hermes.local> (raw)
In-Reply-To: <20210714141300.15280-1-suanmingm@nvidia.com>
On Wed, 14 Jul 2021 17:13:00 +0300
Suanming Mou <suanmingm@nvidia.com> wrote:
> Currently, rte_eal_mp_wait_lcore() function will be called by rte_exit()
> as the routine below:
> rte_exit() -> rte_eal_cleanup() -> rte_service_finalize() ->
> rte_eal_mp_wait_lcore()
>
> As rte_eal_mp_wait_lcore() is announced can only be called from main lcore,
> rte_exit() gets the limitation implicitly as well. Or once rte_exit() is
> called from a worker core, the rte_exit() procedure will get stuck in the
> rte_eal_mp_wait_lcore() function as the core status is still running.
>
> This commit adds the limitation to rte_exit() to make things clear.
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
This patch has had no response in almost two years.
The root cause of the problem is a the assumption in the service library.
That is a bug and should be filed against rte_service, not by having a
caveat in documentation that no one will read anyway.
prev parent reply other threads:[~2023-06-30 3:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 14:13 Suanming Mou
2023-06-30 3:37 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629203720.682f90c3@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).