From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB39B42D65; Fri, 30 Jun 2023 05:37:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D9B0406B5; Fri, 30 Jun 2023 05:37:25 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 7AAC84021F for ; Fri, 30 Jun 2023 05:37:23 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1b7fef01fe4so11025815ad.0 for ; Thu, 29 Jun 2023 20:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688096242; x=1690688242; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=28o31CXgbcntVkvsXW7hE6ZFMqGKMJgOUOa+yoMPt6o=; b=3YpJI2HRDOvvHoTWOjoOYD7ZKtu1C8Bi98ptVR5yzD0b0wbUcyAkstaLjOC+Q0gZ0N JB3U9aQdSqK/HDHh0JaKca1VsDPOErlEWoZKSF58ExD4LZBhoVKQbGN/akCU3A4ZR4j0 p+E8n9Co08sSW+7GHg0j2U71MzDPXchgL6IxVsnGT7Xi5qypfyiQyG+yaIsb7SDw5zb4 aSpo0CZURwy9zEMPVDpQxJFliRAPSF4y36lPbIjwql+Ai47A05VvBGllQr2gyLKJAmWT yQTS+ee6dOrcVs+ND0aYVaDEocA9NNhyQWlOLUrMHT4aCJ2f41Pz6qkhA3VpqPsXYTK0 F33w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688096242; x=1690688242; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=28o31CXgbcntVkvsXW7hE6ZFMqGKMJgOUOa+yoMPt6o=; b=Y6Oz2cOW8LPbBKwNpCw94U17ceQSB2ECbcExPkNv3F+QDZvqGbm/D4XEh078JeyjaF Jch96znkjET/SalfVZ+PioQKHnvm6uBf4svE/B1Jd6JDpc6W7bjJQ7hNvICWmIYMDoDe kXwV489zq9dzHKA5n6Hzk7EP3nOMDNsTnL4SSbu6siZu5c7MwIRw6S7nmKQ5t5AZGIOy 2+G1um59IYa7VJ+p5FnC9tW5vaED1DQmXMgQ+ljjoqzzelfbzo7Wl6YBPPG3ELzxh4V8 2+DdAsy0RhChL0WmtWwA1tbR7uf8x6qn7rNfGXmTFKLm7UeVNs4IwLpSfisqk3qH76lF kZLw== X-Gm-Message-State: ABy/qLaGDFOGjF/Jq1HSC8Cf6t2mrGP823X7NwIKA6wt++TpHJR9+eU9 LXvk5JYDYbkKyh5ysL8gTTPIYA== X-Google-Smtp-Source: APBJJlENDBTAfGsiGZvS2gt6aqu5IekPjjvBtLQs9ztfOYM0Fe5snDU791SN92N2kUPPkCRLjTiSkQ== X-Received: by 2002:a17:902:b711:b0:1b8:6850:c3c4 with SMTP id d17-20020a170902b71100b001b86850c3c4mr761533pls.22.1688096242520; Thu, 29 Jun 2023 20:37:22 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id g24-20020a170902869800b001b531e8a000sm9710201plo.157.2023.06.29.20.37.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 20:37:22 -0700 (PDT) Date: Thu, 29 Jun 2023 20:37:20 -0700 From: Stephen Hemminger To: Suanming Mou , harry.van.haaren@intel.com Cc: , , Subject: Re: [dpdk-dev] [PATCH] eal: add rte_exit() main lcore limitation description Message-ID: <20230629203720.682f90c3@hermes.local> In-Reply-To: <20210714141300.15280-1-suanmingm@nvidia.com> References: <20210714141300.15280-1-suanmingm@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 14 Jul 2021 17:13:00 +0300 Suanming Mou wrote: > Currently, rte_eal_mp_wait_lcore() function will be called by rte_exit() > as the routine below: > rte_exit() -> rte_eal_cleanup() -> rte_service_finalize() -> > rte_eal_mp_wait_lcore() > > As rte_eal_mp_wait_lcore() is announced can only be called from main lcore, > rte_exit() gets the limitation implicitly as well. Or once rte_exit() is > called from a worker core, the rte_exit() procedure will get stuck in the > rte_eal_mp_wait_lcore() function as the core status is still running. > > This commit adds the limitation to rte_exit() to make things clear. > > Signed-off-by: Suanming Mou This patch has had no response in almost two years. The root cause of the problem is a the assumption in the service library. That is a bug and should be filed against rte_service, not by having a caveat in documentation that no one will read anyway.