From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F38C42D98; Fri, 30 Jun 2023 19:47:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61A43410FC; Fri, 30 Jun 2023 19:47:20 +0200 (CEST) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id 5B7BB410FC for ; Fri, 30 Jun 2023 19:47:19 +0200 (CEST) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-53482b44007so1248555a12.2 for ; Fri, 30 Jun 2023 10:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688147238; x=1690739238; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=a5eFAnhppMp7FOVjSgRycMuCr0u8cs38JGm8KM/2sDI=; b=Q95ayCZRunZ2WTM/rjEj9HXRNUUieNAYuzlQVUv0j4PISXrIX8s3t92FtBEG9+Pqp1 vJOHcy2JyHzVypxSgKeMM+Xlw7vB0fT38PUkeH8ys7jmVeScCIb4Lyh9b+JrQXIrpBbQ W4HvrK5uqiH626bBSaxZBU5m/0QRd9uFK0Tm0mMCP5lQjuRVI1ttGzIgHvLd5sJR4K6G 5a7WcVByP+eusHw6hYzduFz+6Ys61YWUHKP1hHXoB194pa5786DdoeOi9V5UgypxKcvN RztXEOoWyGAF12NPQ2YYTcb+PtfOneImco56Rc2DvN5VHHmCG21WgJXgeQNJrXPXNpsn IenQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688147238; x=1690739238; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a5eFAnhppMp7FOVjSgRycMuCr0u8cs38JGm8KM/2sDI=; b=d/CkAHNive04dbyH6q4FrdonvMu7WDiAjULePPbx2HXoatv2oamj4y8Z81xa9tHUJ1 FQn+mWy24REW3RWExdYEJPeVom4daFavstHkES7vElcPZ2w+blVYF8VgJ6EJydyfpHGo Y6BBCCrw+v0ALr7uN0nF2MScpRn+mLXyC4AxUQExZdc+C6OFC1uKQ/0nRgDCJN6fndZk 9dlpcgjl0P38z6QhSFYgaz+M5S1x+yG/D878tZEnWgToDExBP8BPOx3A4xvS7ACrYbXp LPlzkVcXLiAK22o9X9n8ihoOE2cT0AS0XO7qfdPx5543KjufRiROtlcW3kngmFfh/35S ZV6A== X-Gm-Message-State: AC+VfDyEjRno2NkniBIHeSDRASxYTv57hjVahJlCye7n62SlfKFX+q9m Fc84viyQzpcUw1zUVkKiYx+wKQ== X-Google-Smtp-Source: ACHHUZ4fiR0GJsaFc7xXmLiWtqY5l0RDfXJuqTWVG++HkCapX3x/PxKJtXZO8nqxRqPOnqsUkiDozg== X-Received: by 2002:a05:6a20:431c:b0:111:ee3b:59b1 with SMTP id h28-20020a056a20431c00b00111ee3b59b1mr3284443pzk.2.1688147238319; Fri, 30 Jun 2023 10:47:18 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id k16-20020a170902761000b001b3f9a5d4besm11030013pll.255.2023.06.30.10.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 10:47:18 -0700 (PDT) Date: Fri, 30 Jun 2023 10:47:16 -0700 From: Stephen Hemminger To: Vladimir Medvedkin Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH] fib: fix adding a default route Message-ID: <20230630104716.72a29b24@hermes.local> In-Reply-To: <20230630171035.32984-1-vladimir.medvedkin@intel.com> References: <20230630171035.32984-1-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 30 Jun 2023 17:10:35 +0000 Vladimir Medvedkin wrote: > redge = ip + (uint32_t)(1ULL << (32 - depth)); > - if (ledge == redge) > + if ((ledge == redge) && (ledge != 0)) Extra parenthesis are not necessary here.