From: Stephen Hemminger <stephen@networkplumber.org>
To: "Walsh, Conor" <conor.walsh@intel.com>
Cc: Usama Nadeem <usama.nadeem@emumba.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] examples/l3fwd: ipv4 and udp/tcp cksum verification through software
Date: Fri, 30 Jun 2023 14:50:17 -0700 [thread overview]
Message-ID: <20230630145017.506fbff7@hermes.local> (raw)
In-Reply-To: <PH0PR11MB52077D9CF75AD795843EBF6FFF8D9@PH0PR11MB5207.namprd11.prod.outlook.com>
On Thu, 4 Nov 2021 11:11:02 +0000
"Walsh, Conor" <conor.walsh@intel.com> wrote:
> > checks if ipv4 and udptcp cksum offload capability available
> > If not available, cksum is verified through software
> > If cksum is corrupt, packet is dropped, rest of the packets
> > are forwarded back.
> >
> > Bugzilla ID:545
> > Signed-off-by: Usama Nadeem <usama.nadeem@emumba.com>
> > ---
>
> Hi Usama,
>
> This should be done in a generic way that allows all the lookup methods to support it not just LPM.
> check_software_cksum should go in a common file and be called from LPM, FIB and possibly EM.
>
> Thanks,
> Conor.
Agree.
This is a real bug in l3fwd-XXX examples.
It needs to be done in a more general way so that applications can use this
design pattern as a template.
Please submit a new version
next prev parent reply other threads:[~2023-06-30 21:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 12:09 [dpdk-dev] [PATCH] examples: ipv4, udp and tcp checksum offload warning usamanadeem321
2021-09-13 15:11 ` Stephen Hemminger
2021-09-14 18:08 ` [dpdk-dev] [PATCH v2] Warns if IPv4, UDP or TCP checksum offload not available Usama Nadeem
2021-09-14 18:28 ` Stephen Hemminger
2021-09-14 22:22 ` Ananyev, Konstantin
2021-09-14 23:44 ` Stephen Hemminger
2021-09-15 8:43 ` Ananyev, Konstantin
2021-10-08 15:51 ` [dpdk-dev] [PATCH v3] ipv4 and udp/tcp cksum verification through software Usama Nadeem
2021-10-14 18:43 ` [dpdk-dev] [PATCH v4] examples/l3fwd: " Usama Nadeem
2021-11-01 8:33 ` Usama Nadeem
2021-11-04 11:11 ` Walsh, Conor
2021-11-04 16:19 ` Medvedkin, Vladimir
2021-11-16 5:20 ` Usama Nadeem
2021-11-16 5:21 ` Usama Nadeem
2023-06-30 21:50 ` Stephen Hemminger [this message]
2021-11-04 13:19 ` Ananyev, Konstantin
2021-11-16 5:18 ` Usama Nadeem
2022-01-14 9:30 ` Usama Nadeem
2022-01-14 12:05 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630145017.506fbff7@hermes.local \
--to=stephen@networkplumber.org \
--cc=conor.walsh@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=usama.nadeem@emumba.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).