From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35FC542D9A; Fri, 30 Jun 2023 23:50:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5AC2410FC; Fri, 30 Jun 2023 23:50:22 +0200 (CEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id BCD1840EDB for ; Fri, 30 Jun 2023 23:50:20 +0200 (CEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-666fb8b1bc8so1922686b3a.1 for ; Fri, 30 Jun 2023 14:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1688161819; x=1690753819; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=xVkj0T9LboC6MOsMvaGW4Ag1aHdg6MdDAfFilskoVM8=; b=4ApdzBQ/KhBzKbOflXuXwyUaFdkOzfqlYk9OIQrMVN7aeNGmpBbvmSKiiGBtaIa5PL FbRT5n0+S56gtEeNpfMGcUKiUZRKNR/nCYOn4kDJkPG4uDZOYK+90HdZEHl9gS1dk3Ae lNdlvY4Y54eK8s2VoRlkZXAoHCeafpSiofQaJBYH7lXOm8JQPlOMxdHqWET+6t4OujnC lf04SUtsSjkX8t5t+nt5b1/yXtzq9PjWHgzIA11tyNbjUzfd/yjcV1r6eb2/uCCtip/V Zgoc8ptQpFYsHc5AK3xLl8igmz9lEM8tv00CH0ARedBxLSvZzI3tJicclbXmG88OrK2w felA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688161819; x=1690753819; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xVkj0T9LboC6MOsMvaGW4Ag1aHdg6MdDAfFilskoVM8=; b=ccQ1sL37pwPzklhGB5b09O4+GZtv+ahgMSty8lwaYD8dzQbYWsLwG5gRhqCy0Qx3di 1q9IL41pEhpH5S/MVTbSplUUY8bzJ6Vb1dimwwgxCtApzcZJ8M3F90vQJdsvwgRXTQ/l VEIrBgWYG4Nh23oJLGbMJkhQaWlzEbl56x8WoK7ghEiOlUxkpD0zrMKfNMP1oFJ8MHZX aeJLXQovc6kk7m9aa7XZDfbUTei2pe8zvksTQ9+5dZUHdhjk/rZB15sHiNcUcD0r15IC nFbQg5u58cSMX/9VCAmHwKPxqLuytwisXPWUZJpmr5bV+89IR5CqtZWwS4fhWy7Zylfb ekmA== X-Gm-Message-State: ABy/qLa7LM1V+/VrYhULRJZeQk0fT+FFbQy1uuVTYm4mqVIzecuYtEDg cGDN+dJsoX1I3ZDNKjaR8pl8Hg== X-Google-Smtp-Source: ACHHUZ5l6BKqj2GEypniKQLfBmVtb9AgQeV7WppWvw9y5xQ0uUnSNIC78y/AdA9ZbmSRosg9FJvOTw== X-Received: by 2002:a05:6a20:42a6:b0:12d:39c6:9f94 with SMTP id o38-20020a056a2042a600b0012d39c69f94mr4462031pzj.47.1688161819648; Fri, 30 Jun 2023 14:50:19 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id b184-20020a62cfc1000000b00682669dc19bsm1163128pfg.201.2023.06.30.14.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 14:50:19 -0700 (PDT) Date: Fri, 30 Jun 2023 14:50:17 -0700 From: Stephen Hemminger To: "Walsh, Conor" Cc: Usama Nadeem , "thomas@monjalon.net" , "dev@dpdk.org" , "Medvedkin, Vladimir" Subject: Re: [dpdk-dev] [PATCH v4] examples/l3fwd: ipv4 and udp/tcp cksum verification through software Message-ID: <20230630145017.506fbff7@hermes.local> In-Reply-To: References: <20211008155111.125786-1-usama.nadeem@emumba.com> <20211014184322.5148-1-usama.nadeem@emumba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 4 Nov 2021 11:11:02 +0000 "Walsh, Conor" wrote: > > checks if ipv4 and udptcp cksum offload capability available > > If not available, cksum is verified through software > > If cksum is corrupt, packet is dropped, rest of the packets > > are forwarded back. > > > > Bugzilla ID:545 > > Signed-off-by: Usama Nadeem > > --- > > Hi Usama, > > This should be done in a generic way that allows all the lookup methods to support it not just LPM. > check_software_cksum should go in a common file and be called from LPM, FIB and possibly EM. > > Thanks, > Conor. Agree. This is a real bug in l3fwd-XXX examples. It needs to be done in a more general way so that applications can use this design pattern as a template. Please submit a new version